fix(imap): STARTTLS for non-993 ports#1690
Open
kawacukennedy wants to merge 1 commit into
Open
Conversation
Member
Benchmark report — no significant changeMetrics worse: 0 · better: 0 (threshold: ±3%). benchstat outputauto-generated by benchmarks.yml |
kawacukennedy
force-pushed
the
fix/imap-tls-mode
branch
2 times, most recently
from
July 20, 2026 08:02
a920630 to
f362d30
Compare
kawacukennedy
force-pushed
the
fix/imap-tls-mode
branch
from
July 20, 2026 08:22
f362d30 to
6071dae
Compare
kawacukennedy
force-pushed
the
fix/imap-tls-mode
branch
from
July 20, 2026 08:30
6071dae to
2eaa243
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Use STARTTLS for all non-993 IMAP ports, matching the SMTP path logic.
Why?
Fixes #1688
Matcha previously only used STARTTLS on ports 1143 and 143, falling back to implicit TLS on every other port. This broke local IMAP bridges (e.g. Proton Mail Bridge) that serve IMAP on non-standard ports with STARTTLS. Port 993 uses implicit TLS; all other ports now correctly use STARTTLS.