fix: check tmpFile.Close() error in external editor#1339
Open
MD-Mushfiqur123 wants to merge 1 commit into
Open
fix: check tmpFile.Close() error in external editor#1339MD-Mushfiqur123 wants to merge 1 commit into
MD-Mushfiqur123 wants to merge 1 commit into
Conversation
floatpanebot
requested changes
May 22, 2026
Member
floatpanebot
left a comment
floatpanebot
left a comment
There was a problem hiding this comment.
Hi @MD-Mushfiqur123! Please fix the following issues with your PR:
- Title: Is too long (51 characters). The PR title must be strictly under 40 characters.
- Body: Missing the
## What?or## Why?headings required by the PR template.
FromSi
requested changes
May 23, 2026
| tmpPath := tmpFile.Name() | ||
|
|
||
| if _, err := tmpFile.WriteString(body); err != nil { | ||
| tmpFile.Close() |
Member
There was a problem hiding this comment.
tmpFile.Close() is still unchecked in the failed WriteString path. Please wrap the close too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #728. Checked tmpFile.Close() error before opening external editor. If Close fails after writing temp file, the error is returned instead of being silently ignored.