Skip to content

fix(daemon): handle socket errors #1335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
FromSi merged 5 commits into from
May 24, 2026
+6 −2
Merged

fix(daemon): handle socket errors #1335

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c27398e
fix: check errors from os.Remove and os.Chmod in daemon startup
MD-Mushfiqur123 May 22, 2026
b3c2473
Merge branch 'master' into fix/unchecked-daemon-errors
FromSi May 24, 2026
024a4f0
fix(daemon): use safer socket mode
FromSi May 24, 2026
f568115
fix(daemon): document socket mode
FromSi May 24, 2026
71bc66c
fix(daemon): document socket mode
FromSi May 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions daemon/daemon.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,9 @@ func (d *Daemon) Run() error {

// Remove stale socket file.
sockPath := daemonrpc.SocketPath()
os.Remove(sockPath) //nolint:errcheck,gosec
if err := os.Remove(sockPath); err != nil && !os.IsNotExist(err) {
return fmt.Errorf("remove stale socket: %w", err)
}

// Listen on Unix domain socket.
var err error
Expand All @@ -100,7 +102,9 @@ func (d *Daemon) Run() error {
defer d.listener.Close() //nolint:errcheck

// Set socket permissions (owner only).
os.Chmod(sockPath, 0700) //nolint:errcheck,gosec
if err := os.Chmod(sockPath, 0700); err != nil { // #nosec G302
return fmt.Errorf("set socket permissions: %w", err)
}

log.Printf("daemon: listening on %s (PID %d)", sockPath, os.Getpid())

Expand Down
Loading