Skip to content

Refactor/tsam xarray simplify#656

Closed
FBumann wants to merge 2 commits intorefactor/tsam-xarrayfrom
refactor/tsam-xarray-simplify
Closed

Refactor/tsam xarray simplify#656
FBumann wants to merge 2 commits intorefactor/tsam-xarrayfrom
refactor/tsam-xarray-simplify

Conversation

@FBumann
Copy link
Copy Markdown
Member

@FBumann FBumann commented Apr 1, 2026

Description

Brief description of the changes in this PR.

Type of Change

  • Bug fix
  • New feature
  • Documentation update
  • Code refactoring

Related Issues

Closes #(issue number)

Testing

  • I have tested my changes
  • Existing tests still pass

Checklist

  • My code follows the project style
  • I have updated documentation if needed
  • I have added tests for new functionality (if applicable)

FBumann and others added 2 commits April 1, 2026 08:39
…lude_original_data

BREAKING CHANGES:
- Remove ClusteringPlotAccessor (compare, heatmap, clusters methods)
- Remove original_data and aggregated_data from Clustering
- Remove _metrics from Clustering (use aggregation_result.accuracy instead)
- Remove include_original_data parameter from to_dataset/to_netcdf
- Simplify _create_reference_structure to just serialize ClusteringResult dict
- Remove build_metrics from _ReducedFlowSystemBuilder

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…pipeline

Verifies numerical equivalence of expanded solution values for both
non-segmented and segmented clustering, including flow rates, costs,
objectives, shapes, and NaN-free expansion.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 1, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 27f1e721-7151-405c-8991-2f85fdb8dfcc

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch refactor/tsam-xarray-simplify

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@FBumann FBumann closed this Apr 1, 2026
@FBumann FBumann deleted the refactor/tsam-xarray-simplify branch April 1, 2026 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant