-
Notifications
You must be signed in to change notification settings - Fork 9
Feature/types direct #465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Feature/types direct #465
Changes from all commits
Commits
Show all changes
35 commits
Select commit
Hold shift + click to select a range
097f73f
Overhaul types
FBumann 01d4c2d
Introduce Bool data
FBumann a5b37a7
Introduce Bool data
FBumann cd5b72b
Fix typehints
FBumann f188f04
Add EffectData type
FBumann d8bf7f2
EffectData Type - Complete Redesign
FBumann bfc645e
Use NumericData instead of Data
FBumann 2a06dfb
Update type hints
FBumann 9e11da8
Update type hints
FBumann d772169
Use | instead of Union
FBumann 18d5162
Use | instead of Union
FBumann 242eecd
Direct type hints
FBumann d82c5d2
Use direct type hints instead of subscripts
FBumann d4f4df0
Update type hints
FBumann 540f1f8
Update type hints
FBumann cfceef6
Update type documentation
FBumann d0fac14
Update type documentation
FBumann 1187a2c
Update type documentation
FBumann 8abf6fb
Add another datatype
FBumann 73dc336
Fix typehints
FBumann c5afcbd
Fix typehints
FBumann 559a9fe
Fix validation in linear_converter classes
FBumann 94a0ca4
Fix validation in linear_converter classes
FBumann ef1a2ee
pre commit run
FBumann 4fa6c6b
Fix Effect type
FBumann 12bc0a6
Improve Fix: check_bounds function to allow for more types
FBumann 9b4781d
Type Hints: OnOffParameters attribute
FBumann ae59f91
ShareAllocationModel None/inf inconsistency
FBumann 2dd882a
4. Documentation: Effect type docstrings (flixopt/types.py:82-92)
FBumann c80804e
Remove types from init
FBumann d70958b
Lets type hints define types instead of docstring
FBumann 3dda003
Revert changes adressed in another PR
FBumann 420085e
Update CHANGELOG.md
FBumann a76090d
Update CHANGELOG.md
FBumann 1fe8f99
Merge branch 'main' into feature/types-direct
FBumann File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion | 🟠 Major
Import the new public type aliases under TYPE_CHECKING
This module uses
Effect_TPS,Effect_PS,Numeric_TPS, andNumeric_PSin annotations (e.g.,Effect.__init__,EffectCollection.create_effect_values_dict) but theTYPE_CHECKINGimport only brings inEffectData,NumericData,Period,Scalar,Scenario,Time. For static type checking tools, these aliases will appear undefined.Extend the
.typesimport here to include the new aliases that are referenced in this file.🤖 Prompt for AI Agents