-
Notifications
You must be signed in to change notification settings - Fork 9
Feature/v3/feature/367 rename year dimension to period 2 #370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
FBumann
merged 14 commits into
feature/v3/main
from
feature/v3/feature/367-rename-year-dimension-to-period-2
Sep 29, 2025
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
ed9cd75
The framework now uses "period" instead of "year" as the dimension na…
FBumann 870b325
Update CHANGELOG.md
FBumann a555cb5
Remove periods_of_last_period parameter and adjust weights calculation
FBumann d947209
Bugfix
FBumann 75710bf
Bugfix
FBumann a3a9508
Switch from "as_time_series": bool to "dims": [time, period, scenario…
FBumann 4f7fd55
Improve normalization of weights
FBumann 9f1dcff
Update tests
FBumann 4136a9c
Typos in docs
FBumann 918baeb
Improve docstrings
FBumann d99eac7
Improve docstrings
FBumann 1464fcc
Update CHANGELOG.md
FBumann 00e5eca
Improved tests: added extra time+scenarios combination
FBumann d2345f5
Add rename and improve CHANGELOG.md
FBumann File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doc/type mismatch for PeriodicData.
Type alias sets PeriodicData = xr.DataArray, but the docstring says “Can be a Scalar or an xr.DataArray.” Clarify one of:
🤖 Prompt for AI Agents