Add play_theme block for music theme playback#458
Merged
tracygardner merged 2 commits intomainfrom Mar 23, 2026
Merged
Conversation
- Add themeNames export to config.js with the 6 theme-*.mp3 files - Remove theme files from audioNames (play_sound now shows only SFX) - Add play_theme block definition to blocks/sound.js - Add play_theme code generator to generators/generators.js - Add play_theme as first item in the Sound toolbox category - Add translations for play_theme in all 8 locale files (es marked as ai) - Update my_place.flock demo to use play_theme block https://claude.ai/code/session_01SdkF1n3xEoer4ZqQ1Y1Yuz
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (2)
📝 WalkthroughWalkthroughAdds a new Blockly block Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Blockly as Blockly Editor
participant Generator as JS Generator
participant Runtime as Runtime Audio System
User->>Blockly: Insert/configure `play_theme` block
Blockly->>Generator: Export block fields (MESH_NAME, THEME_NAME, SPEED, VOLUME, MODE, ASYNC)
Generator->>Runtime: Emit code -> call playSound(mesh, theme, {loop, volume, playbackRate})
Runtime-->>User: Play audio (start/await based on ASYNC)
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
blocks/sound.js (1)
17-88: LGTM!The
play_themeblock definition correctly mirrors theplay_soundblock pattern with appropriate adaptations:
- Uses
THEME_NAMEfield populated fromthemeNames- Shares
variableNamePrefix = "sound"for consistent variable numbering across sound blocks- Correctly attaches the
dynamic_mesh_dropdownextension and block event handlerConsider improving dropdown readability by transforming theme filenames into user-friendly labels:
💡 Optional: Improve dropdown display names
{ type: "field_dropdown", name: "THEME_NAME", options: function () { - return themeNames.map((name) => [name, name]); + return themeNames.map((name) => { + // Transform "theme-bright.mp3" to "Bright" + const displayName = name + .replace(/^theme-/, "") + .replace(/\.mp3$/, "") + .replace(/^\w/, (c) => c.toUpperCase()); + return [displayName, name]; + }); }, },🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@blocks/sound.js` around lines 17 - 88, The THEME_NAME dropdown currently shows raw filenames from the themeNames array; update the options generator in the Blockly.Blocks["play_theme"] init (the options function for the "THEME_NAME" field) to map each theme name to a user-friendly label (e.g., strip extensions, replace underscores/dashes with spaces, and capitalize words) while preserving the original string as the option value so existing logic using themeNames remains unchanged.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@blocks/sound.js`:
- Around line 17-88: The THEME_NAME dropdown currently shows raw filenames from
the themeNames array; update the options generator in the
Blockly.Blocks["play_theme"] init (the options function for the "THEME_NAME"
field) to map each theme name to a user-friendly label (e.g., strip extensions,
replace underscores/dashes with spaces, and capitalize words) while preserving
the original string as the option value so existing logic using themeNames
remains unchanged.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: d9a4236e-c3f8-495d-bf00-316d3604df3d
📒 Files selected for processing (13)
blocks/sound.jsconfig.jsexamples/my_place.flockgenerators/generators.jslocale/de.jslocale/en.jslocale/es.jslocale/fr.jslocale/it.jslocale/pl.jslocale/pt.jslocale/sv.jstoolbox.js
- Add audioFileToLabel() to config.js: derives display names from SFX filenames (e.g. phaserDown1.mp3 → Phaser Down 1, laser1.mp3 → Laser 1) - Add getThemeDisplayName() to config.js: looks up theme_*_option translation key with fallback capitalisation (e.g. theme-bright.mp3 → Bright) - Update play_theme and play_sound blocks to use these helpers - Add theme_bright/calm/electronic/game/medieval/metal_option to en.js - Add same keys to es.js marked as // ai https://claude.ai/code/session_01SdkF1n3xEoer4ZqQ1Y1Yuz
Deploying flockdev with
|
| Latest commit: |
4fa4706
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://912aeca8.flockdev.pages.dev |
| Branch Preview URL: | https://claude-plan-sound-theme-refa.flockdev.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces a new
play_themeblock that allows users to play background music themes with customizable speed, volume, and playback modes. Theme audio files are now separated from sound effects in the configuration.Key Changes
New Block Definition: Added
play_themeblock inblocks/sound.jswith support for:themeNames)Code Generation: Implemented JavaScript code generator for
play_themeblock that:playSound()calls with theme-specific parametersConfiguration Refactoring: Separated audio assets in
config.js:themeNamesexport containing 6 theme tracks (bright, calm, electronic, game, medieval, metal)audioNamesfor sound effectsToolbox Integration: Added
play_themeblock to the Sound category toolbox with default shadow blocks for speed and volume inputsLocalization: Added translations for the new block and tooltip across 9 languages (English, German, Spanish, French, Italian, Polish, Portuguese, Swedish)
Example Update: Updated
my_place.flockexample to use the newplay_themeblock instead of genericplay_soundfor background musicImplementation Details
play_soundblock with similar parameter structurehttps://claude.ai/code/session_01SdkF1n3xEoer4ZqQ1Y1Yuz
Summary by CodeRabbit
New Features
Documentation