[Hotfix 25.9] fix(updater): rename CustomVolume boundaries to bounding_entities everywhere - #2068
Open
benflexcompute wants to merge 1 commit into
Open
Conversation
…g_entities everywhere _to_25_9_2 renamed `boundaries` -> `bounding_entities` only under meshing.volume_zones/zones, leaving CustomVolume dicts stale in model entities, parent_volume, UDD output_target and asset-cache draft_entities. Add _to_25_9_10 with a whole-dict recursive rename (run-once sentinel, stripped before return) and bump version to 25.9.10. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
_to_25_9_2renamesboundaries->bounding_entitiesonly undermeshing.volume_zones/meshing.zones. CustomVolume dicts everywhere else keep the staleboundarieskey after running the updater:models[*].entities.stored_entities(Rotation / PorousMedium / NavierStokes numerics zones)models[*].parent_volumeuser_defined_dynamics[*].output_targetprivate_attribute_asset_cache.project_entity_info.draft_entitiesValidation still passes today because the
CustomVolumemodel has a before-validator accepting the legacy key, but anything consuming raw updater output seesboundaries.Fix
_rename_custom_volume_boundaries_everywhere(): recursive whole-dict walk renaming the key on everyCustomVolumedict. Run-once sentinel key on the params dict (same pattern as the total-pressure conversion on master schema);updater()strips it before returning._to_25_9_10; version bumped 25.9.9 -> 25.9.10 (milestone must exceed already-deployed 25.9.9 stamps)._to_25_9_2left frozen; data already stamped >= 25.9.2 never re-enters it, the new milestone covers it. Rename is idempotent, so re-walking already-fixed data is a no-op.updater("25.9.3" -> "25.9.10")covering all five missed locations + sentinel cleanup.Part 1/3 of the fix stack: release-25.9 (this PR), release-candidate/25.10 (compute), master (compute).
🤖 Generated with Claude Code
Note
Low Risk
Targeted, idempotent schema migration in the updater path; low risk aside from any consumer that depended on the old
boundarieskey in non-meshing locations.Overview
Fixes incomplete CustomVolume migration:
_to_25_9_2only renamedboundaries→bounding_entitiesunder meshing volume zones, so copies in models, UDDoutput_target, asset-cache draft entities, etc. could still expose the legacy key after upgrade.Adds
_rename_custom_volume_boundaries_everywhere, a full-params recursive walk with a run-once sentinel (removed beforeupdater()returns), wired as milestone25.9.10. Package version is bumped to 25.9.10, with an end-to-end test covering the previously missed locations.Reviewed by Cursor Bugbot for commit c0950a9. Bugbot is set up for automated code reviews on this repo. Configure here.