feat: add autohooks plugin to sort JSON keys in test ref files#1936
Merged
benflexcompute merged 3 commits intorelease-candidate/25.9from Mar 27, 2026
Merged
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9702424334
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
There are 2 total unresolved issues (including 1 from previous review).
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
592f193 to
cd0bf49
Compare
angranl-flex
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
flow360/_autohooks/sort_json.py) that automatically sorts keys in stagedtests/**/*.jsonfilespyproject.tomlalongside existing black, isort, and pylint hooksUsage
After cloning / pulling this branch, activate the pre-commit hooks once:
From now on, every
git commitwill automatically:tests/**/*.jsonreference filesThe hooks only process staged files, so they are fast. If you don't activate, CI will still catch issues.
Test plan
git commitvia autohooks🤖 Generated with Claude Code
Note
Low Risk
Low risk: changes are limited to developer tooling/docs and only mutate staged
tests/**/*.jsonfiles during commits, with no runtime or production code impact.Overview
Adds a new
autohookspre-commit plugin (flow360/_autohooks/sort_json.py) that reusestools/sort_ref_json.pyto sort keys in stagedtests/**/*.jsonfiles, stashing unstaged changes and re-staging updated files for clean diffs.Registers the plugin in
pyproject.tomlalongsideblack/isort/pylint, and updates the README with hook activation instructions plus a manualcheck instep to run the JSON sorter.Written by Cursor Bugbot for commit cd0bf49. This will update automatically on new commits. Configure here.