Skip to content

feat(client): add use_nextflow_pipelines flag to geometry creation#1929

Open
andrzej-krupka wants to merge 2 commits intomainfrom
andrzej/nextflow-geometry-flag
Open

feat(client): add use_nextflow_pipelines flag to geometry creation#1929
andrzej-krupka wants to merge 2 commits intomainfrom
andrzej/nextflow-geometry-flag

Conversation

@andrzej-krupka
Copy link
Copy Markdown
Contributor

@andrzej-krupka andrzej-krupka commented Mar 26, 2026

Expose the useNextflowPipelines flag in the Python client so users can opt into Nextflow-based geometry processing. The flag is passed through Geometry.from_file() -> GeometryDraft -> NewGeometryRequest -> POST /v2/geometries request body.

Defaults to False -- no behavior change for existing users.


Note

Medium Risk
Medium risk because it changes the client-side request payload for geometry creation and adds a new public parameter; incorrect wiring of the flag could silently be ignored or alter processing behavior.

Overview
Adds a new use_nextflow_pipelines option to Geometry.from_file()/GeometryDraft and attempts to forward it into the POST /v2/geometries request so users can opt into Nextflow-based geometry processing.

Extends the NewGeometryRequest model with a useNextflow boolean (default False) to carry this routing choice in the API payload.

Written by Cursor Bugbot for commit 68d2d61. This will update automatically on new commits. Configure here.

@andrzej-krupka andrzej-krupka force-pushed the andrzej/nextflow-geometry-flag branch from 95aae07 to aaadb11 Compare March 27, 2026 16:43
Copy link
Copy Markdown

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

parent_folder_id=self.folder.id if self.folder else "ROOT.FLOW360",
length_unit=self.length_unit,
description=description,
use_nextflow_pipelines=self.use_nextflow_pipelines,
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Field name mismatch: use_nextflow_pipelines vs use_nextflow

High Severity

The NewGeometryRequest model defines the field as use_nextflow, but _create_project_root_resource passes it as use_nextflow_pipelines=self.use_nextflow_pipelines. Since use_nextflow_pipelines matches neither the field name (use_nextflow) nor its alias (useNextflow), Pydantic will raise a validation error at runtime whenever a user tries to create a geometry with this flag.

Additional Locations (1)
Fix in Cursor Fix in Web

andrzej-krupka and others added 2 commits March 27, 2026 13:44
Expose the useNextflowPipelines flag in the Python client so users
can opt into Nextflow-based geometry processing. The flag is passed
through Geometry.from_file() -> GeometryDraft -> NewGeometryRequest
-> POST /v2/geometries request body.

Defaults to False -- no behavior change for existing users.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@lei-flex lei-flex force-pushed the andrzej/nextflow-geometry-flag branch from aaadb11 to 68d2d61 Compare March 27, 2026 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants