fix(ci): version flet-mcp like the other packages on publish#6633
Merged
Conversation
The `build_flet_mcp` job built the wheel at flet-mcp's static pyproject version (0.1.0) instead of the release version, because it only ran `patch_python_package_versions` (which stamps just the core flet/flet-cli/ flet-desktop/flet-web packages) and skipped the per-extension `patch_toml_versions` stamp that `build_flet_extensions` applies to every other package. So every publish re-attempted `flet_mcp-0.1.0`, which already exists on PyPI, and `uv publish` aborted the whole job with `400 File already exists`. Stamp flet-mcp's pyproject with $PYPI_VER before `uv build`, exactly as the extensions job does, so flet-mcp ships at the unified release version.
Deploying flet-website-v2 with
|
| Latest commit: |
e797ef7
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://7eadb9c3.flet-website-v2.pages.dev |
| Branch Preview URL: | https://fix-flet-mcp-version.flet-website-v2.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
v0.86.0.dev0publish failed (run) with:Every other package published at the release version
0.86.0.dev0; onlyflet_mcpwent up as0.1.0(its staticpyproject.tomlversion), which was already on PyPI from an earlier run — souv publish400s and, underbash -eo pipefail, aborts the whole publish job.Root cause
Extension wheels get their version stamped at build time —
build_flet_extensionsrunspatch_toml_versions "packages/<pkg>/pyproject.toml" "$PYPI_VER"beforeuv buildfor each package.flet-mcphas its own build job (build_flet_mcp, because it needs theflet mcp builddata step), and that job only callspatch_python_package_versions— which stamps just the coreflet/flet-cli/flet-desktop/flet-webpackages. Soflet-mcpwas never stamped and built at0.1.0.Fix
Add the same per-package stamp to the
build_flet_mcpjob soflet-mcpships at the unified release version like every other package:patch_toml_versions "packages/flet-mcp/pyproject.toml" "$PYPI_VER"Notes
flet-mcp 0.1.0already exists on PyPI and can't be reused, but that's harmless — future releases now publishflet-mcpat the release version (0.86.0.dev0,0.86.0, …), which supersedes it.0.86.0.dev0wheels from the failed run were all uploaded successfully before the abort, so this only affects future publishes.Based on / targets
flet-0.86.Summary by Sourcery
Build: