Skip to content

fix: replace deprecated delta_x/delta_y with local_delta.x/y in examples and docs #6344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Krishnachaitanyakc wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: replace deprecated delta_x/delta_y with local_delta.x/y in examples and docs #6344

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions sdk/python/examples/controls/gesture_detector/mouse_cursors.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@

def main(page: ft.Page):
def on_pan_update(event: ft.DragUpdateEvent[ft.GestureDetector]):
container.top = max(0.0, container.top + event.delta_y)
container.left = max(0.0, container.left + event.delta_x)
container.top = max(0.0, container.top + event.local_delta.y)
container.left = max(0.0, container.left + event.local_delta.x)
container.update()

gesture_detector = ft.GestureDetector(
Expand Down
4 changes: 2 additions & 2 deletions sdk/python/examples/tutorials/solitaire/solitaire-classes/card.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,8 @@ def start_drag(self, e: ft.DragStartEvent):
self.update()

def drag(self, e: ft.DragUpdateEvent):
self.top = max(0, self.top + e.delta_y)
self.left = max(0, self.left + e.delta_x)
self.top = max(0, self.top + e.local_delta.y)
self.left = max(0, self.left + e.local_delta.x)
self.update()

def drop(self, e: ft.DragEndEvent):
Expand Down
4 changes: 2 additions & 2 deletions sdk/python/examples/tutorials/solitaire/solitaire-drag-and-drop/step1.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@

def main(page: ft.Page):
def drag(e: ft.DragUpdateEvent):
e.control.top = max(0, e.control.top + e.delta_y)
e.control.left = max(0, e.control.left + e.delta_x)
e.control.top = max(0, e.control.top + e.local_delta.y)
e.control.left = max(0, e.control.left + e.local_delta.x)
e.control.update()

card = ft.GestureDetector(
Expand Down
4 changes: 2 additions & 2 deletions sdk/python/examples/tutorials/solitaire/solitaire-drag-and-drop/step2.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,8 @@ def start_drag(e: ft.DragStartEvent):
solitaire.start_left = e.control.left

def drag(e: ft.DragUpdateEvent):
e.control.top = max(0, e.control.top + e.delta_y)
e.control.left = max(0, e.control.left + e.delta_x)
e.control.top = max(0, e.control.top + e.local_delta.y)
e.control.left = max(0, e.control.left + e.local_delta.x)
e.control.update()

def drop(e: ft.DragEndEvent):
Expand Down
4 changes: 2 additions & 2 deletions sdk/python/examples/tutorials/solitaire/solitaire-drag-and-drop/step3.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,8 @@ def start_drag(e: ft.DragStartEvent):
solitaire.start_left = e.control.left

def drag(e: ft.DragUpdateEvent):
e.control.top = max(0, e.control.top + e.delta_y)
e.control.left = max(0, e.control.left + e.delta_x)
e.control.top = max(0, e.control.top + e.local_delta.y)
e.control.left = max(0, e.control.left + e.local_delta.x)
e.control.update()

def drop(e: ft.DragEndEvent):
Expand Down
4 changes: 2 additions & 2 deletions sdk/python/examples/tutorials/solitaire/solitaire-drag-and-drop/step4.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,8 @@ def start_drag(e: ft.DragStartEvent):
solitaire.start_left = e.control.left

def drag(e: ft.DragUpdateEvent):
e.control.top = max(0, e.control.top + e.delta_y)
e.control.left = max(0, e.control.left + e.delta_x)
e.control.top = max(0, e.control.top + e.local_delta.y)
e.control.left = max(0, e.control.left + e.local_delta.x)
e.control.update()

def drop(e: ft.DragEndEvent):
Expand Down
4 changes: 2 additions & 2 deletions sdk/python/examples/tutorials/solitaire/solitaire-fanned-piles/card.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,10 +74,10 @@ def start_drag(self, e: ft.DragStartEvent):
def drag(self, e: ft.DragUpdateEvent):
for card in self.draggable_pile:
card.top = (
max(0, self.top + e.delta_y)
max(0, self.top + e.local_delta.y)
+ self.draggable_pile.index(card) * CARD_OFFSET
)
card.left = max(0, self.left + e.delta_x)
card.left = max(0, self.left + e.local_delta.x)
self.solitaire.update()

def drop(self, e: ft.DragEndEvent):
Expand Down
4 changes: 2 additions & 2 deletions sdk/python/examples/tutorials/solitaire/solitaire-final-part1/card.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,10 +107,10 @@ def drag(self, e: ft.DragUpdateEvent):
if self.face_up:
for card in self.draggable_pile:
card.top = (
max(0, self.top + e.delta_y)
max(0, self.top + e.local_delta.y)
+ self.draggable_pile.index(card) * CARD_OFFSET
)
card.left = max(0, self.left + e.delta_x)
card.left = max(0, self.left + e.local_delta.x)
self.solitaire.update()

def drop(self, e: ft.DragEndEvent):
Expand Down
4 changes: 2 additions & 2 deletions sdk/python/examples/tutorials/solitaire/solitaire-final/card.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,10 +59,10 @@ def drag(self, e: ft.DragUpdateEvent):
if self.can_be_moved():
i = 0
for card in self.get_cards_to_move():
card.top = max(0, self.top + e.delta_y)
card.top = max(0, self.top + e.local_delta.y)
if card.slot.type == "tableau":
card.top += i * self.solitaire.card_offset
card.left = max(0, self.left + e.delta_x)
card.left = max(0, self.left + e.local_delta.x)
i += 1
self.solitaire.update()

Expand Down
4 changes: 2 additions & 2 deletions sdk/python/examples/tutorials/solitaire/solitaire-game-rules/card.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,10 +104,10 @@ def drag(self, e: ft.DragUpdateEvent):
if self.face_up:
for card in self.draggable_pile:
card.top = (
max(0, self.top + e.delta_y)
max(0, self.top + e.local_delta.y)
+ self.draggable_pile.index(card) * CARD_OFFSET
)
card.left = max(0, self.left + e.delta_x)
card.left = max(0, self.left + e.local_delta.x)
self.solitaire.update()

def drop(self, e: ft.DragEndEvent):
Expand Down
4 changes: 2 additions & 2 deletions sdk/python/examples/tutorials/solitaire/solitaire-game-setup/card.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,10 +90,10 @@ def start_drag(self, e: ft.DragStartEvent):
def drag(self, e: ft.DragUpdateEvent):
for card in self.draggable_pile:
card.top = (
max(0, self.top + e.delta_y)
max(0, self.top + e.local_delta.y)
+ self.draggable_pile.index(card) * CARD_OFFSET
)
card.left = max(0, self.left + e.delta_x)
card.left = max(0, self.left + e.local_delta.x)
self.solitaire.update()

def drop(self, e: ft.DragEndEvent):
Expand Down
16 changes: 8 additions & 8 deletions sdk/python/packages/flet/docs/tutorials/solitaire.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,8 +105,8 @@ import flet as ft

def main(page: ft.Page):
def drag(e: ft.DragUpdateEvent):
e.control.top = max(0, e.control.top + e.delta_y)
e.control.left = max(0, e.control.left + e.delta_x)
e.control.top = max(0, e.control.top + e.local_delta.y)
e.control.left = max(0, e.control.left + e.local_delta.x)
e.control.update()

card = ft.GestureDetector(
Expand Down Expand Up @@ -424,8 +424,8 @@ class Card(ft.GestureDetector):
self.update()

def drag(self, e: ft.DragUpdateEvent):
self.top = max(0, self.top + e.delta_y)
self.left = max(0, self.left + e.delta_x)
self.top = max(0, self.top + e.local_delta.y)
self.left = max(0, self.left + e.local_delta.x)
self.update()

def drop(self, e: ft.DragEndEvent):
Expand Down Expand Up @@ -585,10 +585,10 @@ positions of all the cards being dragged:
def drag(self, e: ft.DragUpdateEvent):
for card in self.draggable_pile:
card.top = (
max(0, self.top + e.delta_y)
max(0, self.top + e.local_delta.y)
+ self.draggable_pile.index(card) * CARD_OFFSET
)
card.left = max(0, self.left + e.delta_x)
card.left = max(0, self.left + e.local_delta.x)
self.solitaire.update()
```

Expand Down Expand Up @@ -910,8 +910,8 @@ def start_drag(self, e: ft.DragStartEvent):
def drag(self, e: ft.DragUpdateEvent):
if self.face_up:
for card in self.draggable_pile:
card.top = max(0, self.top + e.delta_y) + self.draggable_pile.index(card) * CARD_OFFSET
card.left = max(0, self.left + e.delta_x)
card.top = max(0, self.top + e.local_delta.y) + self.draggable_pile.index(card) * CARD_OFFSET
card.left = max(0, self.left + e.local_delta.x)
card.solitaire.update()

def drop(self, e: ft.DragEndEvent):
Expand Down
Loading