Add socket_path to containerd tables#47987
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
WalkthroughA new Linux-only helper file ( 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #47987 +/- ##
==========================================
- Coverage 67.31% 67.30% -0.01%
==========================================
Files 3655 3656 +1
Lines 231242 231256 +14
Branches 12076 12221 +145
==========================================
- Hits 155658 155650 -8
- Misses 61619 61637 +18
- Partials 13965 13969 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
0a0429a to
c1a438a
Compare
lucasmrod
left a comment
There was a problem hiding this comment.
LGTM. Thanks for the contribution!
Please add a changes file under orbit/changes/.
Also left two nit doc comments.
Co-authored-by: Lucas Manuel Rodriguez <lucarodriguez@gmail.com>
3562f01 to
cfa8d44
Compare
Thanks for the review @lucasmrod! Pushed the changelog and fixed the docs, should be good to go! |
|
Changes smoke tested in Linux. |
Related issue: Resolves #48006.
Adds a new field
socket_pathin bothcontainerd_containersandcontainerd_mounts. We keep the previous default when nosocket_pathis requested in the filter; otherwise, we honor the value passed from the incoming query.Test case:
Ran a
make fleetd-tables-linux, started some containers, then used osquery:Checklist for submitter
If some of the following don't apply, delete the relevant line.
Changes file added for user-visible changes in
changes/,orbit/changes/oree/fleetd-chrome/changes.See Changes files for more information.
Input data is properly validated,
SELECT *is avoided, SQL injection is prevented (using placeholders for values in statements), JS inline code is prevented especially for url redirects, and untrusted data interpolated into shell scripts/commands is validated against shell metacharacters.Timeouts are implemented and retries are limited to avoid infinite loops
If paths of existing endpoints are modified without backwards compatibility, checked the frontend/CLI for any necessary changes
Testing
Added/updated automated tests
Where appropriate, automated tests simulate multiple hosts and test for host isolation (updates to one hosts's records do not affect another)
QA'd all new/changed functionality manually
For unreleased bug fixes in a release candidate, one of:
Database migrations
COLLATE utf8mb4_unicode_ci).New Fleet configuration settings
If you didn't check the box above, follow this checklist for GitOps-enabled settings:
fleetctl generate-gitopsfleetd/orbit/Fleet Desktop
runtime.GOOSis used as needed to isolate changesSummary by CodeRabbit
Summary by CodeRabbit
New Features
socket_pathcolumn tocontainerd_containersandcontainerd_mounts./run/containerd/containerd.sockwhen not provided).Documentation
socket_pathcolumn and example queries (including common k3s socket paths).Tests
socket_pathbehavior.