feat: add customizable delay to individual tile loading#2224
Draft
JaffaKetchup wants to merge 3 commits into
Draft
feat: add customizable delay to individual tile loading#2224JaffaKetchup wants to merge 3 commits into
JaffaKetchup wants to merge 3 commits into
Conversation
Minor change to Android demo app build config
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sparked by the fix #2217, and discussed with @mootw.
At the moment, tiles start loading (ignoring the influence of
TileUpdateTransformer) after they become visible. If they are destroyed, then loading is stopped (assuming the tile provider can support this, which it does by default).However, it would be better not to start loading tiles that the user is unlikely to look at. Unfortunately this is difficult to estimate. Therefore, this introduces a delay on each individual tile load.
During fast gestures, the tile will therefore be destroyed before it starts loading, which has numerous benefits (including potentially speeding up tile loading of the tiles we do want by reducing interfering network traffic, although that was reduced by the universal introduction of abortable loading).
The tradeoff is another 30 milliseconds (by default) for each tile to load, which is barely noticable, but is not insignificant in the numbers.