revert: fix: throw when LatLng is non-finite#2218
Open
JaffaKetchup wants to merge 2 commits into
Open
Conversation
mootw
approved these changes
Jun 30, 2026
mootw
left a comment
mootw
left a comment
Contributor
There was a problem hiding this comment.
looks good. maybe we look at resolving the re-opened issue on the marker layer level.
Are there any places internally in FM that generate NaN's, or is this purely an end user inputs bad data causes weird behavior downstream?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #2182 (which is fdc089a)
Fixes #2199. Reopens #2178.