fix: load tiles during double-tap-and-drag (one finger) zoom gesture#2217
Open
ProstoSanja wants to merge 1 commit into
Open
fix: load tiles during double-tap-and-drag (one finger) zoom gesture#2217ProstoSanja wants to merge 1 commit into
ProstoSanja wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: load tiles during double-tap-and-drag (one finger) zoom gesture
Problem
The double-tap-and-drag zoom gesture (double-tap, hold, then drag to zoom with
one finger —
InteractiveFlag.doubleTapDragZoom) doesn't load new tiles whilethe gesture is ongoing. The map zooms visually, but
TileLayerkeeps showingthe stale/upscaled/missing tiles and only loads the correct ones once the finger is
released. Pinch-to-zoom is unaffected by this behaviour.
Root cause
TileLayeronly loads tiles in response to events onMapController.mapEventStream. Every gesture-driven camera change flows throughMapControllerImpl.moveRaw, which builds its event viaMapEventWithMove.fromSource(...)(lib/src/gestures/map_events.dart):MapInteractiveViewer._handleDoubleTapHolddrives the gesture withmoveRaw(..., source: MapEventSource.doubleTapHold), butdoubleTapHoldisn'tin the switch, so
fromSourcereturnsnulland noMapEventis emittedfor the whole gesture.
The existing
//! PREVENTS TILE LOADING IF SOURCE NOT CONFIGURED IN CONSTRUCTORcomment in
moveRawpoints at exactly this gap.Testing
test/map/map_events_test.dart, assertingfromSource(... source: doubleTapHold)returns aMapEventMove(withonMultiFingeras a baseline).AI usage disclosure