-
Notifications
You must be signed in to change notification settings - Fork 2
Feat: Add YAML validation for compose content in deployment flows #46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| VITE_API_URL=http://localhost:8080 | ||
| VITE_API_URL=http://localhost:8090/api | ||
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -0,0 +1,21 @@ | ||||||
| import { parse } from "yaml"; | ||||||
|
|
||||||
| export type ComposeYamlValidation = { valid: true } | { valid: false; error: string }; | ||||||
|
|
||||||
| /** | ||||||
| * This function validates that a string is valid YAML. It is used before sending compose content | ||||||
| * to the API (e.g.during a deployment update or create). | ||||||
| */ | ||||||
| export function validateComposeYaml(content: string): ComposeYamlValidation { | ||||||
| const trimmed = content.trim(); | ||||||
| if (!trimmed) { | ||||||
| return { valid: false, error: "Compose content is empty" }; | ||||||
| } | ||||||
| try { | ||||||
| parse(trimmed); | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. By default, the
Suggested change
|
||||||
| return { valid: true }; | ||||||
| } catch (err: unknown) { | ||||||
| const message = err instanceof Error ? err.message : "Invalid YAML syntax"; | ||||||
| return { valid: false, error: message }; | ||||||
| } | ||||||
| } | ||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The API URL has been changed from port 8080 to 8090 and appended with /api. Ensure this change is intentional for the example environment and matched in server-side configurations.