builder-flatpak-utils: Normalize the single trailing slash in pattern#677
Open
builder-flatpak-utils: Normalize the single trailing slash in pattern#677
Conversation
ced12ee to
029ee89
Compare
029ee89 to
196eb82
Compare
Contributor
Author
|
any comments on this? |
swick
reviewed
Apr 2, 2026
Comment on lines
164
to
167
| case 0: | ||
| if (*string == '/' || *string == 0) | ||
| return string; | ||
| return NULL; |
Contributor
There was a problem hiding this comment.
This handles the inverse. Could add something like
case '/':
if (*string == '/')
string++;
else if (*string != 0)
return NULL;
break;
Contributor
Author
There was a problem hiding this comment.
that does not work directly
Contributor
Author
There was a problem hiding this comment.
i had to do this, but this copies case 0 again.
case '/':
if (*pattern == 0)
{
/* treat as directory boundary, don't consume */
if (*string == '/' || *string == 0)
return string;
return NULL;
}
if (*string == '/')
string++;
else if (*string != 0)
return NULL;
break;
Contributor
|
Not sure if I would consider this a bug in the first place. Kind of depends on what you consider a path prefix I guess. |
Contributor
Author
|
according to the man, patterns are taken to be either the full pathname or basename, not normalising is a bit weird. it also accepts |
196eb82 to
47d8312
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #476