[2.x] fix(testing): reorder boot sequence in OverrideExtensionManagerForTests#4719
Draft
DavideIadeluca wants to merge 4 commits into
Draft
[2.x] fix(testing): reorder boot sequence in OverrideExtensionManagerForTests#4719DavideIadeluca wants to merge 4 commits into
OverrideExtensionManagerForTests#4719DavideIadeluca wants to merge 4 commits into
Conversation
Previously $extensionManager->booted was not recognized because the ExtensionManager itself doesn't have this property whereas `ExtensionManagerIncludeCurrent` has it
$extensionManager->booted = true;OverrideExtensionManagerForTests
OverrideExtensionManagerForTestsOverrideExtensionManagerForTests
OverrideExtensionManagerForTestsOverrideExtensionManagerForTests
OverrideExtensionManagerForTestsOverrideExtensionManagerForTests
Contributor
Author
|
Let's revisit this after 2.0 stable has been released. Fixing #4600 is technically a breaking change in the testing suite as e.g. 2nd or 3rd party vendors might already have assertions in place which assume that language packs are not working |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4600
Reorder the boot sequence in
OverrideExtensionManagerForTests to fix locale translations never loading in integration tests as described in #4600.LocaleManagerwas being resolved duringonEnable()beforeextend()had registered the localeresolving()callbacks. This fix runsextend()first (withbooted=true), then theenable()loop (withbooted=falseso migrations still run).Changes proposed in this pull request:
Reviewers should focus on:
Screenshot
Necessity
Confirmed
composer test).Required changes: