fix(codex): emit complete correlated tool results - #66
Draft
adityathebe wants to merge 1 commit into
Draft
Conversation
Amp-Thread-ID: https://ampcode.com/threads/T-019ff040-e1ff-77e4-85ac-b1fc40495f4a Co-authored-by: Aditya Thebe <contact@adityathebe.com>
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Gavel summary
Totals: 0 passed · 0 failed · 0 skipped · - |
Gavel summary
Totals: 3541 passed · 0 failed · 10 skipped · 2m23s |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #12
Main already maps Codex command starts to
EventToolUse, buffers output deltas, and emits a correlatedEventToolResulton completion.However, Codex 0.147 can omit the first output chunk from both its deltas and
aggregatedOutput. This PR finishes the implementation by correlating the complete rawfunction_call_outputwith the command, while retaining the existing accumulated output as a fallback.Tested with the provider test suite, race detector, and a live authenticated Codex run.