Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 🚀 New features to boost your workflow:
|
📝 WalkthroughWalkthroughThis PR introduces Poe task runner as a unified command interface, replacing direct tool invocations in CI workflows with Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Poem
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
This PR integrates poethepoet (poe) as a task runner to standardize and centralize command execution in CI/CD workflows. It replaces direct tool invocations with poe task references, making the build commands more maintainable and consistent across different environments.
Changes:
- Added poethepoet dependency (>=0.32.0) to dev dependencies with version-specific installations (0.37.0 for Python <3.10, 0.41.0 for Python >=3.10)
- Defined poe tasks in pyproject.toml for common operations (lint, format, typecheck, test, docs, build)
- Updated GitHub Actions workflows to use poe commands instead of direct tool invocations
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| uv.lock | Added poethepoet package entries with version-specific markers and its pastel dependency |
| pyproject.toml | Added poethepoet to dev dependencies and configured poe tasks for linting, formatting, testing, and building |
| .github/workflows/python.yml | Replaced direct tool commands with poe task references in CI workflow |
| .github/workflows/docs.yml | Replaced pydoc-markdown command with poe docs task |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@pyproject.toml`:
- Around line 116-134: The test POE task in pyproject.toml only collects
coverage for fishaudio; update the "test" task definition to include coverage
for the second package by adding the missing flag --cov=src/fish_audio_sdk to
the test command so both --cov=src/fishaudio and --cov=src/fish_audio_sdk are
passed to pytest; locate the "test" task entry under [tool.poe.tasks] and append
the additional --cov flag to the existing command string.
Summary by CodeRabbit