[BHP1-1503] Remove Wind Adjustment Factor for Spot Wind-Driven#202
Merged
[BHP1-1503] Remove Wind Adjustment Factor for Spot Wind-Driven#202
Conversation
Collaborator
|
Result value and conditionals working according to the test. However this work is leading me into some questions about what happens when the user also selects "Midflame Windspeed" as an output. Currently this will give an output of 0, since even though we hide WAF, we are still setting the wind adjustment method to UserInput so when calculating midflame windspeed it will use 0 as the WAF, causing "Midflame Windspeed" to return 0. If this is the intended behavior then I think we just need to add the output "Midflame Windspeed" to the set of sub conditionals. But perhaps this belongs in a separate ticket. Approved current changes anyway. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
EOM
Related Issues
Closes BHP1-1503
Submission Checklist
BHP1-### <title>)clj-kondo --lint components/**/src bases/**/src projects/**/src)clojure -M:compile-cljs)Testing
Run migration
migrations.2026-03-21-hide-waf-for-spot-only, syncCreate a new Surface-only worksheet (standard workflow)
Select Output > Spot > Max Spotting Distance from Wind-Driven
Surface Fire
Go to inputs, verify that "Wind Adjustment Factor" is not shown
Use the following inputs:
20ft20mph10ft20ft2000ft1mileRidge Top0.4miles (matches Behave Dev)