Skip to content

[BHP1-1503] Remove Wind Adjustment Factor for Spot Wind-Driven#202

Merged
rjsheperd merged 2 commits intomainfrom
rj-BHP1-1503-remove-waf-spot-wind-driven-only
Mar 30, 2026
Merged

[BHP1-1503] Remove Wind Adjustment Factor for Spot Wind-Driven#202
rjsheperd merged 2 commits intomainfrom
rj-BHP1-1503-remove-waf-spot-wind-driven-only

Conversation

@rjsheperd
Copy link
Copy Markdown
Contributor

Purpose

EOM

Related Issues

Closes BHP1-1503

Submission Checklist

  • Included Jira issue in the PR title (e.g. BHP1-### <title>)
  • Code passes linter rules (clj-kondo --lint components/**/src bases/**/src projects/**/src)
  • Feature(s) work when compiled (clojure -M:compile-cljs)

Testing

  1. Run migration migrations.2026-03-21-hide-waf-for-spot-only, sync

  2. Create a new Surface-only worksheet (standard workflow)

  3. Select Output > Spot > Max Spotting Distance from Wind-Driven
    Surface Fire

  4. Go to inputs, verify that "Wind Adjustment Factor" is not shown

  5. Use the following inputs:

  • Wind Speed Height: 20 ft
  • Wind Speed: 20 mph
  • Surface Flame Length: 10 ft
  • Downwind Canopy Height: 20 ft
  • Ridge-To-Valley Elevation Difference: 2000 ft
  • Ridge-To-Valley Horizontal Distance: 1 mile
  • Spotting Source Location: Ridge Top
  1. Run worksheet, verify output is 0.4 miles (matches Behave Dev)

@Kcheung42
Copy link
Copy Markdown
Collaborator

Kcheung42 commented Mar 30, 2026

Result value and conditionals working according to the test.

However this work is leading me into some questions about what happens when the user also selects "Midflame Windspeed" as an output.

Currently this will give an output of 0, since even though we hide WAF, we are still setting the wind adjustment method to UserInput so when calculating midflame windspeed it will use 0 as the WAF, causing "Midflame Windspeed" to return 0.
Should the expected behavior be that we use the calculated WAF?

See:
https://github.com/firelab/behave/blob/7bfd16422fcb2439af2f7adfd3ed1aae8277943d/src/behave/surfaceFire.cpp#L538-L545

If this is the intended behavior then I think we just need to add the output "Midflame Windspeed" to the set of sub conditionals. But perhaps this belongs in a separate ticket.

Approved current changes anyway.

@rjsheperd rjsheperd merged commit ff013e3 into main Mar 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants