fixes protection connrate as stated in #319#320
Open
sagar-chandarana wants to merge 1 commit intofirehol:masterfrom
Open
fixes protection connrate as stated in #319#320sagar-chandarana wants to merge 1 commit intofirehol:masterfrom
protection connrate as stated in #319#320sagar-chandarana wants to merge 1 commit intofirehol:masterfrom
Conversation
Member
|
Hi, are you sure this works? The |
Author
|
Yes it's been tested and is working. ${rate} = $[1] so it is not needed to
be separate from the arguments.
…On Sat, Mar 24, 2018 at 8:51 AM, Costa Tsaousis ***@***.***> wrote:
Hi, are you sure this works? The ${rate} is not used anywhere now...
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#320 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ADXEuSHfNjkUokAX3_EmmGhHXt43m1opks5thjNcgaJpZM4Sd3Gd>
.
|
philwhineray
force-pushed
the
master
branch
2 times, most recently
from
10a5660 to
022c26d
Compare
|
I see the PR was merged. |
Author
|
I don't see currently my changes on the present master |
Author
|
perhaps after forced pushes, do we need a new PR? Anyways, it's a one line change. #319 is confirmed by one more user |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes
protection connrateas stated in #319