Pass profile upgrade info to stateFromLocation in compare view#5890
Pass profile upgrade info to stateFromLocation in compare view#5890ojuschugh1 wants to merge 1 commit intofirefox-devtools:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5890 +/- ##
=======================================
Coverage 85.42% 85.43%
=======================================
Files 321 321
Lines 32073 32076 +3
Branches 8821 8823 +2
=======================================
+ Hits 27398 27403 +5
+ Misses 4244 4242 -2
Partials 431 431 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mstange
left a comment
There was a problem hiding this comment.
Thanks! So you're calling stateFromLocation twice now. I think it would be better to make it clear that the first call is only aiming to get the "data source" information about the URL. If you look at the code which handles non-compare URLs, it's doing manual splitting of the URL to get those pieces of information. Can you move the data source determination code into a shared place and use it from both call sites, so that stateFromLocation is only called once we have the profile upgrade info?
This PR fixes #5871