Skip to content

Pass profile upgrade info to stateFromLocation in compare view#5890

Open
ojuschugh1 wants to merge 1 commit intofirefox-devtools:mainfrom
ojuschugh1:fix-compare-url-upgraders
Open

Pass profile upgrade info to stateFromLocation in compare view#5890
ojuschugh1 wants to merge 1 commit intofirefox-devtools:mainfrom
ojuschugh1:fix-compare-url-upgraders

Conversation

@ojuschugh1
Copy link

This PR fixes #5871

@codecov
Copy link

codecov bot commented Mar 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.43%. Comparing base (23fea36) to head (9253007).
⚠️ Report is 7 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5890   +/-   ##
=======================================
  Coverage   85.42%   85.43%           
=======================================
  Files         321      321           
  Lines       32073    32076    +3     
  Branches     8821     8823    +2     
=======================================
+ Hits        27398    27403    +5     
+ Misses       4244     4242    -2     
  Partials      431      431           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@mstange mstange left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! So you're calling stateFromLocation twice now. I think it would be better to make it clear that the first call is only aiming to get the "data source" information about the URL. If you look at the code which handles non-compare URLs, it's doing manual splitting of the URL to get those pieces of information. Can you move the data source determination code into a shared place and use it from both call sites, so that stateFromLocation is only called once we have the profile upgrade info?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

When loading comparison URLs, we're not supplying the individual URL upgraders with the profile info

2 participants