Fix dev server rejecting non-localhost hosts when using FX_PROFILER_HOST#5889
Open
ojuschugh1 wants to merge 1 commit intofirefox-devtools:mainfrom
Open
Fix dev server rejecting non-localhost hosts when using FX_PROFILER_HOST#5889ojuschugh1 wants to merge 1 commit intofirefox-devtools:mainfrom
ojuschugh1 wants to merge 1 commit intofirefox-devtools:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5889 +/- ##
=======================================
Coverage 85.42% 85.42%
=======================================
Files 321 321
Lines 32073 32073
Branches 8821 8823 +2
=======================================
Hits 27398 27398
Misses 4244 4244
Partials 431 431 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mstange
requested changes
Mar 12, 2026
Contributor
mstange
left a comment
mstange
left a comment
There was a problem hiding this comment.
Thanks! Some small comments but overall looks good.
Comment on lines
+42
to
+44
| const allowedHosts = BASE_ALLOWED_HOSTS.includes(host) | ||
| ? BASE_ALLOWED_HOSTS | ||
| : [...BASE_ALLOWED_HOSTS, host]; |
Contributor
There was a problem hiding this comment.
Let's just always do [...BASE_ALLOWED_HOSTS, host], checking the same host twice is not a problem.
| const BASE_ALLOWED_HOSTS = ['localhost', '.app.github.dev']; | ||
|
|
||
| function isHostAllowed(hostHeader) { | ||
| function isHostAllowed(hostHeader, host) { |
Contributor
There was a problem hiding this comment.
host as an argument name is not very descriptive, maybe boundHost might be better? Or extraAllowedHost?
|
|
||
| return allowedHosts.some((allowedHost) => { | ||
| if (allowedHost.startsWith('.')) { | ||
| // Wildcard pattern like '.app.github.dev' |
Contributor
There was a problem hiding this comment.
Can we keep this comment? It seems useful
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #5865