Rework form generation around incidents and templates#620
Open
chetanr25 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rework form generation around incidents and templates
Why
Form generation was still built around a single extraction and a closed list of form types, from before templates were user-registered and before extraction started producing a stored incident. Two separate endpoints for one form versus all forms did not make sense once generation is just a lookup, not an LLM call.
What changed
generate/allandgenerate/{form_type}are now onePOST /forms/generate, taking anincident_idand a list oftemplate_ids. Leavingtemplate_idsout generates everything the readiness matrix reports as ready.incident_id, since the contract document now lives on the incident row rather than the extraction.force_partialis set.FormRecordshape.GET /forms/batch/{batch_id}/downloadto pull a batch as one archive.Reference
Discussion: #609.
Related Issue: #619