fix(ci): green up v26.06.95 (ruff + mypy --strict)#125
Merged
Conversation
- registry.py: narrow getattr(...) via isinstance(direct, str) so display_name has no Any return (mypy --strict no-any-return). - tests: use the PEP 604 form (_A | None) instead of typing.Optional (ruff UP). Keeps v26.06.95 green on Lint + Mypy + Test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #124. The union-safe
display_namefix needed two CI touch-ups:isinstancenarrowing so mypy --strict sees astrreturn, and the PEP 604 form in the test (ruff). Lint + mypy (673 files) + tests all green locally.