Skip to content

PCPatch: support exterior facet integrals #4878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
connorjward merged 11 commits into from
Mar 26, 2026
Merged

PCPatch: support exterior facet integrals #4878

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
d855add
external integrals
miguelcoolchips Feb 10, 2026
d8a66d0
Merge branch 'main' into patch_pc_external_integrals
miguelcoolchips Mar 18, 2026
47462eb
srclint
miguelcoolchips Mar 18, 2026
bc3cdfc
formatting
miguelcoolchips Mar 18, 2026
c39d828
recover formatting
miguelcoolchips Mar 18, 2026
d175b5e
fix make lint
miguelcoolchips Mar 18, 2026
946e898
Update tests/firedrake/regression/test_patch_pc.py
miguelcoolchips Mar 19, 2026
20d0ac5
Update tests/firedrake/regression/test_patch_pc.py
miguelcoolchips Mar 19, 2026
67660b8
Fix PatchPC exterior facet handling: filter patch-boundary facets cor…
miguelcoolchips Mar 19, 2026
bf01acf
Fix point2facetnumber to span full facet plex range
miguelcoolchips Mar 19, 2026
5675627
Fix point2facetnumber to use full plex chart range
miguelcoolchips Mar 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions firedrake/cython/patchimpl.pyx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@ from libc.stdint cimport uintptr_t

include "petschdr.pxi"

def set_patch_residual(patch, function, ctx, is_snes=False, interior_facets=False):
def set_patch_residual(patch, function, ctx, is_snes=False, interior_facets=False, exterior_facets=False):
if is_snes:
if interior_facets:
if interior_facets or exterior_facets:
raise NotImplementedError
CHKERR(SNESPatchSetComputeFunction((<PETSc.SNES?>patch).snes,
<PetscPCPatchComputeFunction><uintptr_t>function,
Expand All @@ -14,15 +14,19 @@ def set_patch_residual(patch, function, ctx, is_snes=False, interior_facets=Fals
CHKERR(PCPatchSetComputeFunctionInteriorFacets((<PETSc.PC?>patch).pc,
<PetscPCPatchComputeFunction><uintptr_t>function,
<void *><uintptr_t>ctx))
elif exterior_facets:
CHKERR(PCPatchSetComputeFunctionExteriorFacets((<PETSc.PC?>patch).pc,
<PetscPCPatchComputeFunction><uintptr_t>function,
<void *><uintptr_t>ctx))
else:
CHKERR(PCPatchSetComputeFunction((<PETSc.PC?>patch).pc,
<PetscPCPatchComputeFunction><uintptr_t>function,
<void *><uintptr_t>ctx))


def set_patch_jacobian(patch, function, ctx, is_snes=False, interior_facets=False):
def set_patch_jacobian(patch, function, ctx, is_snes=False, interior_facets=False, exterior_facets=False):
if is_snes:
if interior_facets:
if interior_facets or exterior_facets:
raise NotImplementedError
CHKERR(SNESPatchSetComputeOperator((<PETSc.SNES?>patch).snes,
<PetscPCPatchComputeOperator><uintptr_t>function,
Expand All @@ -32,6 +36,10 @@ def set_patch_jacobian(patch, function, ctx, is_snes=False, interior_facets=Fals
CHKERR(PCPatchSetComputeOperatorInteriorFacets((<PETSc.PC?>patch).pc,
<PetscPCPatchComputeOperator><uintptr_t>function,
<void *><uintptr_t>ctx))
elif exterior_facets:
CHKERR(PCPatchSetComputeOperatorExteriorFacets((<PETSc.PC?>patch).pc,
<PetscPCPatchComputeOperator><uintptr_t>function,
<void *><uintptr_t>ctx))
else:
CHKERR(PCPatchSetComputeOperator((<PETSc.PC?>patch).pc,
<PetscPCPatchComputeOperator><uintptr_t>function,
Expand Down
2 changes: 2 additions & 0 deletions firedrake/cython/petschdr.pxi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,6 +179,8 @@ cdef extern from "petscpc.h" nogil:
PetscErrorCode PCPatchSetComputeFunctionInteriorFacets(PETSc.PetscPC, PetscPCPatchComputeFunction, void *)
PetscErrorCode PCPatchSetComputeOperator(PETSc.PetscPC, PetscPCPatchComputeOperator, void *)
PetscErrorCode PCPatchSetComputeOperatorInteriorFacets(PETSc.PetscPC, PetscPCPatchComputeOperator, void *)
PetscErrorCode PCPatchSetComputeOperatorExteriorFacets(PETSc.PetscPC, PetscPCPatchComputeOperator, void *)
PetscErrorCode PCPatchSetComputeFunctionExteriorFacets(PETSc.PetscPC, PetscPCPatchComputeFunction, void *)

cdef extern from "petscbt.h" nogil:
ctypedef char * PetscBT
Expand Down
3 changes: 2 additions & 1 deletion firedrake/mesh.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1331,7 +1331,8 @@ def merge_ids(x, y, datatype):
self._cell_numbering,
self.cell_closure)

point2facetnumber = np.full(facets.max(initial=0)+1, -1, dtype=IntType)
_, pEnd = dm.getChart()
point2facetnumber = np.full(pEnd, -1, dtype=IntType)
point2facetnumber[facets] = np.arange(len(facets), dtype=IntType)
obj = _Facets(self, facets, classes, set_, kind,
facet_cell, local_facet_number,
Expand Down
Loading
Loading