Assembly of matfree interpolation operator#4778
Open
leo-collins wants to merge 28 commits intomainfrom
Open
Conversation
leo-collins
force-pushed
the
leo/assemble-matfree-interpolate
branch
from
57e5d2d to
5019974
Compare
pbrubeck
reviewed
Dec 12, 2025
pbrubeck
reviewed
Dec 12, 2025
pbrubeck
reviewed
Dec 12, 2025
pbrubeck
reviewed
Dec 12, 2025
pbrubeck
reviewed
Dec 12, 2025
pbrubeck
reviewed
Dec 14, 2025
pbrubeck
reviewed
Dec 14, 2025
leo-collins
force-pushed
the
leo/assemble-matfree-interpolate
branch
from
75de8e2 to
5464cce
Compare
connorjward
requested changes
Jan 5, 2026
Contributor
connorjward
left a comment
connorjward
left a comment
There was a problem hiding this comment.
I'm only reviewing this from a high level, but this seems pretty much fine.
Contributor
Author
|
@connorjward Thanks for the review. I'm at a workshop this week and then on holiday again next week so I'll take a look after these. Thanks! |
leo-collins
force-pushed
the
leo/assemble-matfree-interpolate
branch
from
d25e1f2 to
9a9af0f
Compare
pbrubeck
reviewed
Jan 21, 2026
pbrubeck
reviewed
Jan 21, 2026
pbrubeck
reviewed
Jan 21, 2026
pbrubeck
reviewed
Jan 21, 2026
pbrubeck
reviewed
Jan 21, 2026
pbrubeck
reviewed
Jan 21, 2026
pbrubeck
reviewed
Jan 21, 2026
pbrubeck
reviewed
Jan 21, 2026
pbrubeck
reviewed
Jan 21, 2026
leo-collins
commented
Jan 22, 2026
pbrubeck
reviewed
Jan 22, 2026
leo-collins
force-pushed
the
leo/assemble-matfree-interpolate
branch
from
63bd9e1 to
0c16219
Compare
dham
reviewed
Feb 5, 2026
dham
reviewed
Feb 5, 2026
leo-collins
force-pushed
the
leo/assemble-matfree-interpolate
branch
2 times, most recently
from
3336b12 to
f6cdeb2
Compare
leo-collins
force-pushed
the
leo/assemble-matfree-interpolate
branch
from
ef522b2 to
4283a70
Compare
connorjward
requested changes
Apr 21, 2026
Contributor
connorjward
left a comment
connorjward
left a comment
There was a problem hiding this comment.
I think this is 99.9% there. I think I'm happy to merge after these tiny points are addressed.
| test, trial = a | ||
| arguments = a | ||
| else: | ||
| assert isinstance(a, ufl.BaseForm | slate.TensorBase) |
Contributor
There was a problem hiding this comment.
Assertions should only ever be encountered in non-user facing code. This should raise a TypeError instead.
| ): | ||
| """Initialise a :class:`MatrixBase`. | ||
|
|
||
| Parameters |
Contributor
There was a problem hiding this comment.
Nitpick: the arguments to __init__ are supposed to be documented in the class docstring (https://numpydoc.readthedocs.io/en/latest/format.html#class-docstring)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow assembly of matfree interpolation operators by passing
mat_type="matfree".Also changes the interfaces to the matrix classes and
ImplicitMatrixContextto make them simpler.