BDDC: cellwise subdomains, matfree MatIS, and user-defined primal vertices#4757
Merged
BDDC: cellwise subdomains, matfree MatIS, and user-defined primal vertices#4757
Conversation
connorjward
reviewed
Dec 1, 2025
pbrubeck
force-pushed
the
pbrubeck/bddc-primal-vertices
branch
from
8414e2d to
29972f5
Compare
pbrubeck
force-pushed
the
pbrubeck/bddc-primal-vertices
branch
from
29972f5 to
9e69d99
Compare
pbrubeck
force-pushed
the
pbrubeck/bddc-primal-vertices
branch
from
868f5c8 to
af8b9e8
Compare
pbrubeck
force-pushed
the
pbrubeck/submesh-comm-self
branch
3 times, most recently
from
5d4cdbd to
34bad7b
Compare
pbrubeck
force-pushed
the
pbrubeck/submesh-comm-self
branch
from
34bad7b to
2df0024
Compare
pbrubeck
force-pushed
the
pbrubeck/bddc-primal-vertices
branch
from
ffca638 to
2f2e77d
Compare
Member
JHopeCollins
left a comment
JHopeCollins
left a comment
There was a problem hiding this comment.
Generally looks fine, I just have some small questions.
pbrubeck
commented
Feb 13, 2026
pbrubeck
commented
Feb 13, 2026
Co-authored-by: Josh Hope-Collins <joshua.hope-collins13@imperial.ac.uk>
pbrubeck
commented
Feb 13, 2026
Co-authored-by: Josh Hope-Collins <joshua.hope-collins13@imperial.ac.uk>
pbrubeck
commented
Feb 13, 2026
pbrubeck
commented
Feb 13, 2026
pbrubeck
commented
Feb 13, 2026
pbrubeck
commented
Feb 13, 2026
JHopeCollins
approved these changes
Feb 13, 2026
j-bowhay
pushed a commit
to j-bowhay/firedrake
that referenced
this pull request
Feb 24, 2026
connorjward
pushed a commit
that referenced
this pull request
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds new features for BDDC.
-bddc_cellwiseenables cellwise subdomains.-bddc_matfreeenables a matfree MatIS to be used for the interior solver.appctx["primal_markers"].