Merged
Conversation
|
|
ksagiyam
force-pushed
the
ksagiyam/use_canonical_quadrature_point_ordering
branch
from
774be77 to
8608356
Compare
ksagiyam
force-pushed
the
ksagiyam/use_canonical_quadrature_point_ordering
branch
from
8608356 to
fc82421
Compare
ksagiyam
changed the title
ksagiyam
force-pushed
the
ksagiyam/use_canonical_quadrature_point_ordering
branch
from
fc82421 to
49b1000
Compare
dham
approved these changes
Jan 22, 2025
indiamai
pushed a commit
that referenced
this pull request
Feb 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #3874
Follow up [PR for interior facet integration of hex] (firedrakeproject/tsfc#317)
TSFC:
Some ufl-gem translation contexts for interior facet integration (such as the ones for
CellVolumeandFacetArea) do not even need to check if quadrature point ordering on the '+' and '-' sides agree or not. This PR explicitly setPointSetcontext.use_canonical_quadrature_point_ordering=Falsefor those translation contexts.Firedrake:
Add more tests for interior facet integration of hex.