Skip to content

fix(cli): handle wrapper argv parsing#129

Merged
abimaelmartell merged 7 commits into
mainfrom
abi/fix-node24-argv-parsing
Jun 8, 2026
Merged

fix(cli): handle wrapper argv parsing#129
abimaelmartell merged 7 commits into
mainfrom
abi/fix-node24-argv-parsing

Conversation

@abimaelmartell

@abimaelmartell abimaelmartell commented Jun 8, 2026

Copy link
Copy Markdown
Member

Summary

Explicitly parse user-facing CLI arguments before handing off to Commander so wrapper-provided entry script paths are not treated as subcommands on newer Node/npm combinations. This also adds a focused argv regression test and a Node 24 npm-package smoke matrix across Ubuntu, macOS, and Windows so the packaged npx --package <tarball> firecrawl ... path is covered alongside the existing compiled binary checks.

@abimaelmartell abimaelmartell marked this pull request as ready for review June 8, 2026 17:19
@abimaelmartell abimaelmartell merged commit db25ace into main Jun 8, 2026
7 checks passed
@abimaelmartell abimaelmartell deleted the abi/fix-node24-argv-parsing branch June 8, 2026 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant