Auto-update dependencies.#2819
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the Android Gradle Plugin (AGP) to version 9.3.0 and Kotlin to 2.4.10 in the version catalog, and bumps the Android Lint dependencies to 32.3.0. The reviewer recommends migrating these hardcoded Lint dependencies, as well as the JUnit dependency, to the Gradle Version Catalog (gradle/libs.versions.toml) to establish a single source of truth and avoid version drift.
| compileOnly("com.android.tools.lint:lint-api:32.3.0") | ||
| testImplementation("com.android.tools.lint:lint:32.3.0") | ||
| testImplementation("com.android.tools.lint:lint-tests:32.3.0") |
There was a problem hiding this comment.
To maintain a single source of truth for all dependencies and avoid version drift, these Android Lint dependencies should be defined in the Gradle Version Catalog (gradle/libs.versions.toml) instead of being hardcoded here.\n\nYou can add the following to gradle/libs.versions.toml:\n\ntoml\n[versions]\nandroidLint = "32.3.0"\n\n[libraries]\nandroid-tools-lint-api = { module = "com.android.tools.lint:lint-api", version.ref = "androidLint" }\nandroid-tools-lint = { module = "com.android.tools.lint:lint", version.ref = "androidLint" }\nandroid-tools-lint-tests = { module = "com.android.tools.lint:lint-tests", version.ref = "androidLint" }\n\n\nAdditionally, since junit is already defined in the version catalog, you can also migrate testImplementation("junit:junit:4.13.2") to testImplementation(libs.junit).
compileOnly(libs.android.tools.lint.api)
testImplementation(libs.android.tools.lint)
testImplementation(libs.android.tools.lint.tests)86d2e1a to
e2a087d
Compare
Wiz Scan Summary
To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension. |
Brought to you by your friendly Repository Gardener.