Skip to content

fix(appcheck,macos): fix how appAttestWithDeviceCheckFallback is working on fallback #18568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Lyokone wants to merge 2 commits into
base: main
Choose a base branch
from
+42 −4
Open

fix(appcheck,macos): fix how appAttestWithDeviceCheckFallback is working on fallback #18568

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d375415
fix(appcheck,macos): fix how appAttestWithDeviceCheckFallback is work…
Lyokone Aug 14, 2026
c816ead
test(appcheck): assert App Attest is not selected instead of matching…
Lyokone Aug 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 32 additions & 0 deletions packages/firebase_app_check/firebase_app_check/example/integration_test/e2e_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,38 @@ void main() {
skip: defaultTargetPlatform != TargetPlatform.iOS,
);

test(
'appAttestWithDeviceCheckFallback falls back rather than erroring',
() async {
await FirebaseAppCheck.instance.activate(
providerApple:
const AppleAppAttestWithDeviceCheckFallbackProvider(),
);

// On devices without App Attest support — most Macs, and every
// simulator — the provider has to fall back to DeviceCheck. It used
// to pick App Attest purely on OS version and fail with "The
// attestation provider AppAttestProvider is not supported on current
// platform and OS version", so App Attest must not be the provider
// named in any error. Fetching a token can still fail beyond that
// (simulators do not support DeviceCheck either, and there is no
// debug token configured), which is fine here.
try {
await FirebaseAppCheck.instance.getToken(true);
} on FirebaseException catch (e) {
expect(
'${e.message}',
isNot(contains('AppAttestProvider')),
reason: 'the DeviceCheck fallback did not engage',
);
}
},
skip: defaultTargetPlatform != TargetPlatform.macOS &&
defaultTargetPlatform != TargetPlatform.iOS
? 'Apple platforms only.'
: null,
);

test(
'uses Apple debug token when both Android and Apple debug tokens are configured',
() async {
Expand Down
14 changes: 10 additions & 4 deletions ..._app_check/ios/firebase_app_check/Sources/firebase_app_check/FirebaseAppCheckPlugin.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

import DeviceCheck
import FirebaseAppCheck
import FirebaseCore

Expand Down Expand Up @@ -371,11 +372,16 @@ class AppCheckProviderWrapper: NSObject, AppCheckProvider {
delegateProvider = AppCheckDebugProvider(app: app)
}
case "appAttestWithDeviceCheckFallback":
if #available(iOS 14.0, macOS 14.0, *) {
delegateProvider = AppAttestProvider(app: app)
} else {
delegateProvider = DeviceCheckProvider(app: app)
// A new enough OS is not sufficient: the device must also support App
// Attest, which is often false on macOS. The SDK only reports that when a
// token is first requested, so check the same capability it checks —
// otherwise this provider never actually falls back. Typed as the
// protocol to keep the availability-annotated type inside `#available`.
var appAttestProvider: (any AppCheckProvider)?
if #available(iOS 14.0, macOS 14.0, *), DCAppAttestService.shared.isSupported {
appAttestProvider = AppAttestProvider(app: app)
}
delegateProvider = appAttestProvider ?? DeviceCheckProvider(app: app)
case "recaptcha":
#if os(iOS)
if let recaptchaSiteKey {
Expand Down
Loading