fix(web): WASM - After a SignOut with an active authStateChange/idTokenChange a null check would be thrown#18386
fix(web): WASM - After a SignOut with an active authStateChange/idTokenChange a null check would be thrown#18386MattyBoy4444 wants to merge 1 commit into
Conversation
…e a null check error would be thrown
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. |
|
Hi @MattyBoy4444, thanks for the contribution! Could you also add a test covering this change? It would also be helpful to open an issue with reproducible steps and link this PR to it. |
|
Testing isn't setup in firebase_auth_web. What would you expect the test to do? Its just a simple null check error fix. Please merge. |
Description
When WASM is being used, a SignOut with an active authStateChange/idTokenChange would throw a null check error
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]).This will ensure a smooth and quick review process. Updating the
pubspec.yamland changelogs is not required.///).melos run analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?