feat(firestore): introduce pipeline functionality (Dart API)#18096
feat(firestore): introduce pipeline functionality (Dart API)#18096SelaseKay wants to merge 47 commits intofeat/firestore-pipelinesfrom
Conversation
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. |
…/flutterfire into firestore-pipelines-dart-api-v2
…d exports Made-with: Cursor
Lyokone
left a comment
Lyokone
left a comment
There was a problem hiding this comment.
We are also missing a lot of unit tests for a lot files.
| if (selectable10 != null) selectables.add(selectable10); | ||
| if (selectable21 != null) selectables.add(selectable21); |
There was a problem hiding this comment.
We are missing 11 to 20 here
| part of 'cloud_firestore.dart'; | ||
|
|
||
| /// Result of executing a pipeline | ||
| class PipelineResult { |
There was a problem hiding this comment.
This file should be in src.
| BooleanExpression tryExpr, | ||
| BooleanExpression catchExpr, | ||
| ) { | ||
| return _IfErrorExpression(tryExpr, catchExpr) as BooleanExpression; |
There was a problem hiding this comment.
Not sure this cast will work?
…d snapshot handling
…sions in pipeline expressions
… pipeline expressions
wu-hui
left a comment
wu-hui
left a comment
There was a problem hiding this comment.
Did a quick skim, and couple nits. Overall my ask is: can we copy Android's refdocs, and verify they have similar APIs, I suppose ask an AI to compare the two, and copy some from Android might do 80% of this rather tedious work.
Also, I take that the E2E integration tests are (will be) in a different PR?
| /// | ||
| /// Example: | ||
| /// ```dart | ||
| /// pipeline.aggregateStage( |
There was a problem hiding this comment.
This sample does not match the actual method signature. Or am I reading dart right?
There was a problem hiding this comment.
Yes. You're right. I've updated it. Thanks
| ); | ||
| } | ||
|
|
||
| /// Gets distinct values based on expressions |
There was a problem hiding this comment.
Sure, will add samples.
Yes. E2E will be added in a different PR. |
…r drive for integration tests
…ore pipeline example
…up for Swift Package Manager
| } | ||
|
|
||
| /// Returns an expression if another errors | ||
| static Expression ifErrorStatic( |
There was a problem hiding this comment.
general question, why do we have the "static" suffix for some static functions, but not all of them. Ideally we would have no such suffixes, but i guess they exist because Dart complains?
There was a problem hiding this comment.
Yes, Dart does not support function overloading. The goal here is to keep the API style consistent with the native SDKs. For example, on Android, there are multiple overloads of ifError; one as an instance method and another as a static method on the Expression class. To mirror this in Dart, we implemented two methods on the same Expression class and suffixed the static methods with “static,” since Dart does not allow multiple methods with the same name on a single class.
3 participants
Description
Replace this paragraph with a description of what this PR is doing. If you're modifying existing behavior, describe the existing behavior, how this PR is changing it, and what motivated the change.
Related Issues
Replace this paragraph with a list of issues related to this PR from the issue database. Indicate, which of these issues are resolved or fixed by this PR. Note that you'll have to prefix the issue numbers with flutter/flutter#.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]).This will ensure a smooth and quick review process. Updating the
pubspec.yamland changelogs is not required.///).melos run analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?