feat(auth): onUpgradeFailure callback when account linking fails#1355
feat(auth): onUpgradeFailure callback when account linking fails#1355russellwheatley wants to merge 6 commits into
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces an onUpgradeFailure callback to the anonymous upgrade behaviors, allowing for custom error handling and suppression during the linking process. The changes include new type definitions, a centralized error handling utility, and updated logic for both credential and provider linking handlers. A critical issue was identified in the provider linking implementation where the unconditional removal of the user ID from local storage in a finally block would disrupt the redirect flow.
|
I think I'd like to get some integration tests setup for this before going further with this PR as there are some changes to core behaviour. |
|
Hello, this PR has been open for more than 28 days with no activity. If you think this is a mistake, please comment to keep this open. Thanks for contributing!
|
onUpgradeFailurecallback for anonymous user auto-upgrade failures."handled".closes #1354
Below demonstrates
onUpgradeFailurefiring when auto upgrade anonymous user fails and also returns "handled" so error message does not appear in the UI.Screen.Recording.2026-05-07.at.16.47.44.mov