[Remote Config] Add Custom Signals - #1503
Open
a-maurice wants to merge 5 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds support for setting Custom Signals in Remote Config, including C# API bindings, SWIG interface updates, and corresponding UI and automated test cases. The review feedback highlights two important improvements: first, explicitly disposing of SWIG-wrapped StringList and VariantList objects in SetCustomSignalsAsync to prevent unmanaged memory leaks, along with adding a defensive check against null keys; second, resolving a potential race condition in the automated test by directly awaiting both FetchAsync and ActivateAsync instead of relying on FetchDataAsync which does not await activation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add support for setting Custom Signals in Remote Config. Note that this depends on firebase/firebase-cpp-sdk#1899
Testing
Running the tests locally on Android/iOS/Mac.
Type of Change
Place an
xthe applicable box:Feature Request:
#1210