Skip to content

Analytics: Add apple store kit 2 support#1460

Open
AustinBenoit wants to merge 3 commits into
mainfrom
storekit2
Open

Analytics: Add apple store kit 2 support#1460
AustinBenoit wants to merge 3 commits into
mainfrom
storekit2

Conversation

@AustinBenoit
Copy link
Copy Markdown
Contributor

Description

Provide details of the change, and generalize the change in the PR title above.

Analytics: Add apple store kit 2 support for logging apple transactions.


Testing

Describe how you've tested these changes.

Test locally with simulator and simulated Apple transaction:

image

Added in additional integration tests to validate the other platforms are error free.


Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

@AustinBenoit AustinBenoit added the tests-requested: full Trigger a FULL set of integration tests (uses expanded test matrix). label May 15, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces support for Apple's StoreKit 2 transactions in Firebase Analytics by adding the LogAppleTransactionAsync method. The update includes necessary SWIG configurations for async support, a new UI test button and automated test case in the sample app, and detailed documentation for iOS testing. Review feedback primarily identified several typos and capitalization issues in the C# documentation, the test app readme, and the release notes.

Comment thread analytics/src/FirebaseAnalytics.cs Outdated
Comment thread analytics/src/FirebaseAnalytics.cs Outdated
Comment thread analytics/testapp/readme.md Outdated
Comment thread docs/readme.md Outdated
@AustinBenoit AustinBenoit added tests-requested: full Trigger a FULL set of integration tests (uses expanded test matrix). and removed tests-requested: full Trigger a FULL set of integration tests (uses expanded test matrix). labels May 19, 2026
@github-actions github-actions Bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: full Trigger a FULL set of integration tests (uses expanded test matrix). labels May 19, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 19, 2026

✅  Integration test succeeded!

Requested by @firebase-workflow-trigger[bot] on commit dc5d29a
Last updated: Fri May 22 08:53 PDT 2026
View integration test log & download artifacts

@github-actions github-actions Bot added the tests: failed This PR's integration tests failed. label May 19, 2026
@firebase-workflow-trigger firebase-workflow-trigger Bot removed the tests: in-progress This PR's integration tests are in progress. label May 19, 2026
@AustinBenoit AustinBenoit removed the tests: failed This PR's integration tests failed. label May 22, 2026
@AustinBenoit AustinBenoit added the tests-requested: quick Trigger a quick set of integration tests. label May 22, 2026
@github-actions github-actions Bot added tests: in-progress This PR's integration tests are in progress. tests: succeeded This PR's integration tests succeeded. and removed tests-requested: quick Trigger a quick set of integration tests. labels May 22, 2026
@firebase-workflow-trigger firebase-workflow-trigger Bot removed the tests: in-progress This PR's integration tests are in progress. label May 22, 2026
@AustinBenoit AustinBenoit requested a review from a-maurice May 22, 2026 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tests: succeeded This PR's integration tests succeeded.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant