chore(deps): update archiver to v8 - #10885
Open
gameroman wants to merge 1 commit into
Open
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request upgrades the archiver dependency to version 8.0.0 and updates archive instantiations to use new archiver.ZipArchive() and new archiver.TarArchive(). The review feedback correctly points out that these classes are not constructible at runtime and will cause TypeErrors. It is recommended to revert to using the archiver() factory function and to keep the parameter types as archiver.Archiver to avoid type mismatch issues.
Member
|
Unfortunately, this change seems to break the build (see https://github.com/firebase/firebase-tools/actions/runs/31027269420/job/92378818386?pr=10885). I'm guess that this related to v8 of archiver swapping to native esm, but i've not looked into it too closely yet |
gameroman
force-pushed
the
update-archiver-dependency
branch
from
August 8, 2026 21:51
91e36bb to
064cfc5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updates
archiverdependency to v8Scenarios Tested
Sample Commands