fix: tolerate 404 when deleting scheduled function's schedule - #10884
Open
IzaakGough wants to merge 4 commits into
Open
fix: tolerate 404 when deleting scheduled function's schedule#10884IzaakGough wants to merge 4 commits into
IzaakGough wants to merge 4 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the Fabricator to ignore 404 errors when deleting Cloud Scheduler jobs or Pub/Sub topics, ensuring that already-deleted resources do not cause deployment failures. The feedback suggests using the existing parseErrorCode utility from ./executor instead of getErrStatus to more robustly detect 404 status codes from raw GCP API errors, and removing the unused import.
IzaakGough
marked this pull request as ready for review
August 6, 2026 10:36
wandamora
approved these changes
Aug 6, 2026
wandamora
left a comment
wandamora
left a comment
Contributor
There was a problem hiding this comment.
LGTM for google review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4795
When deleting a scheduled function,
firebase deployfailed the whole deployment if the Cloud Scheduler job or its Pub/Sub topic was already gone (404). Deleting a resource that doesn't exist is the desired end state, so these deletes now tolerate a 404 and continue; non-404 errors still fail as before.This unblocks users who hit a partially-deleted schedule and could not deploy again without manual cleanup.
Testing