Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces autocomplete support and diagnostics for the @Allow directive in Firebase Data Connect, including a new completion provider, a schema-parsing service, and quick fixes for missing directives. Feedback identifies several performance and architectural improvements: replacing synchronous file system operations with asynchronous ones to avoid blocking the extension host, optimizing AST parsing for completions and diagnostics, refining the field tokenizer to correctly handle GraphQL punctuation, and consolidating duplicated utility functions for unwrapping GraphQL types.
mtr002
force-pushed
the
mtr-lsp
branch
2 times, most recently
from
6fafa67 to
c51c32d
Compare
…ostics for mutations with _Data variables
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Scenarios Tested
Sample Commands