[AppCheck] Add getLimitedUseToken support to AppCheckProvider#8204
[AppCheck] Add getLimitedUseToken support to AppCheckProvider#8204rlazo wants to merge 9 commits into
Conversation
Introduced the getLimitedUseToken() method to the AppCheckProvider interface and implemented it across the debug, Play Integrity, and reCAPTCHA Enterprise providers. The implementation ensures that token exchange requests include a "limited_use" flag, allowing for the generation of short-lived, single-use App Check tokens.
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. |
|
/gemini review |
📝 PRs merging into main branchOur main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request implements the getLimitedUseToken() method across the AppCheckProvider interface and its various implementations, including Debug, Play Integrity, and reCAPTCHA Enterprise. The changes include updating request objects to support the limited_use flag in JSON payloads and refactoring provider logic. Review feedback identified several improvement opportunities, such as correcting an incorrect class reference and duplicate assertions in ExchangeDebugTokenRequestTest, removing redundant stubbing in DefaultFirebaseAppCheckTest, and improving code clarity through parameter name comments and more idiomatic Truth assertions.
Added a fix for limited use token generation to App Check, Debug, and Play Integrity changelogs. Also updated the debug testing SDK changelog to reflect SDK version alignment.
VinayGuthal
left a comment
VinayGuthal
left a comment
There was a problem hiding this comment.
Fix failing tests source code changes look good
3 participants
Introduced the getLimitedUseToken() method to the AppCheckProvider interface and implemented it across the debug, Play Integrity, and reCAPTCHA Enterprise providers. The implementation ensures that token exchange requests include a "limited_use" flag, allowing for the generation of short-lived, single-use App Check tokens.
Verified manually using debug provider