Skip to content

Prevent R8 to strip out RequireBuildId boolean resource#8145

Merged
mrober merged 1 commit into
firebase:mainfrom
SimonMarquis:patch-1
May 14, 2026
Merged

Prevent R8 to strip out RequireBuildId boolean resource#8145
mrober merged 1 commit into
firebase:mainfrom
SimonMarquis:patch-1

Conversation

@SimonMarquis
Copy link
Copy Markdown
Contributor

@SimonMarquis SimonMarquis commented May 12, 2026

  • without: bool:com_crashlytics_RequireBuildId:2131034114 is not reachable
  • with: bool:com_crashlytics_RequireBuildId:2131034114 reachable from keep xml file

Note: _ are used instead of . because periods are not valid characters.

Fixes #8146

- without: `bool:com_crashlytics_RequireBuildId:2131034114 is not reachable`
- with: `bool:com_crashlytics_RequireBuildId:2131034114 reachable from keep xml file`

Note: `_` are used instead of `.` because periods are not valid characters.
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

@mrober mrober enabled auto-merge (squash) May 14, 2026 16:09
@mrober mrober merged commit de74730 into firebase:main May 14, 2026
29 of 31 checks passed
@SimonMarquis SimonMarquis deleted the patch-1 branch May 14, 2026 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RequireBuildId boolean resource is removed by R8

2 participants