Skip to content

chore: Add node: prefix to crypto imports#3144

Merged
lahirumaramba merged 2 commits into
mainfrom
lm-crypto
May 14, 2026
Merged

chore: Add node: prefix to crypto imports#3144
lahirumaramba merged 2 commits into
mainfrom
lm-crypto

Conversation

@lahirumaramba
Copy link
Copy Markdown
Member

Prefix native crypto module imports with node: across source files and tests. This explicitly distinguishes the built-in Node.js module from third-party packages, aligning with modern ESM and cross-runtime compatibility standards (e.g., Cloudflare Workers, Deno, Bun).

@lahirumaramba lahirumaramba added the release:stage Stage a release candidate label May 13, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the codebase to use the node: prefix for all crypto module imports and requires, ensuring consistency and following modern Node.js conventions. Some minor whitespace adjustments were also made in the test files. I have no feedback to provide.

Copy link
Copy Markdown
Collaborator

@jonathanedey jonathanedey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!

@lahirumaramba lahirumaramba merged commit 67d6d82 into main May 14, 2026
16 checks passed
@lahirumaramba lahirumaramba deleted the lm-crypto branch May 14, 2026 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release:stage Stage a release candidate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants