chore(snippets): updated code samples to use ADC and supported APIs by lahirumaramba · Pull Request #752 · firebase/firebase-admin-go

lahirumaramba · 2026-03-09T22:07:44Z

Updated code samples in the snippets directory to use Application Default Credentials (ADC) wherever appropriate instead of requiring explicit service account keys. Also replaced the deprecated messaging APIs SendAll and SendMulticast with their modern, supported equivalents SendEach and SendEachForMulticast.

gemini-code-assist · 2026-03-09T22:09:10Z

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors several code samples to align with best practices and updated API standards. It transitions Firebase app initialization from explicit service account keys to Application Default Credentials, simplifying authentication. Additionally, it modernizes Firebase Messaging usage by replacing deprecated batch and multicast send functions with their currently supported counterparts, ensuring the samples remain functional and demonstrate recommended API usage.

Highlights

Application Default Credentials (ADC): Updated code samples in snippets/db.go and snippets/storage.go to use Application Default Credentials (ADC) for Firebase app initialization, removing the explicit requirement for service account key files.
Firebase Messaging API Updates: Replaced deprecated Firebase Messaging APIs SendAll and SendMulticast with their modern equivalents, SendEach and SendEachForMulticast, in snippets/messaging.go.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

snippets/db.go
- Removed the google.golang.org/api/option import.
- Updated authenticateWithAdminPrivileges to initialize the Firebase app without option.WithCredentialsFile.
- Updated authenticateWithLimitedPrivileges to initialize the Firebase app without option.WithCredentialsFile.
- Updated authenticateWithGuestPrivileges to initialize the Firebase app without option.WithCredentialsFile.
snippets/messaging.go
- Replaced client.SendAll with client.SendEach in the sendAll function.
- Replaced client.SendMulticast with client.SendEachForMulticast in the sendMulticast function.
- Replaced client.SendMulticast with client.SendEachForMulticast in the sendMulticastAndHandleErrors function.
snippets/storage.go
- Removed the google.golang.org/api/option import.
- Updated cloudStorage to initialize the Firebase app without option.WithCredentialsFile.

Activity

No specific activity (comments, reviews, progress) was provided in the context for this pull request.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request updates code samples to use Application Default Credentials (ADC) and modern Firebase APIs, which is a great improvement. The changes to use ADC in db.go and storage.go are correct. The updates in messaging.go to replace deprecated SendAll and SendMulticast APIs are also correct.

My review includes a few suggestions for snippets/messaging.go to improve context handling and address code duplication that arose from these changes. Specifically, several functions are not propagating the context they receive, and some functions have become duplicates of others.

gemini-code-assist · 2026-03-09T22:10:44Z

snippets/messaging.go

 	}

-	br, err := client.SendAll(context.Background(), messages)
+	br, err := client.SendEach(context.Background(), messages)


The function receives a ctx context.Context parameter, but context.Background() is used here. To allow for proper context propagation (for cancellation, deadlines, tracing, etc.), you should use the ctx variable that is passed into the function.

Suggested change

br, err := client.SendEach(context.Background(), messages)

br, err := client.SendEach(ctx, messages)

gemini-code-assist · 2026-03-09T22:10:44Z

snippets/messaging.go

 	}

-	br, err := client.SendAll(context.Background(), messages)
+	br, err := client.SendEach(context.Background(), messages)


With this change, the sendAll function has become functionally identical to the existing sendEach function. This introduces code duplication, which can make maintenance more difficult. Please consider refactoring to remove the duplication, for example by removing this function and updating callers to use sendEach.

gemini-code-assist · 2026-03-09T22:10:44Z

snippets/messaging.go

 	}

-	br, err := client.SendMulticast(context.Background(), message)
+	br, err := client.SendEachForMulticast(context.Background(), message)


The function receives a ctx context.Context parameter, but context.Background() is used here. To allow for proper context propagation (for cancellation, deadlines, tracing, etc.), you should use the ctx variable that is passed into the function.

Suggested change

br, err := client.SendEachForMulticast(context.Background(), message)

br, err := client.SendEachForMulticast(ctx, message)

gemini-code-assist · 2026-03-09T22:10:44Z

snippets/messaging.go

 	}

-	br, err := client.SendMulticast(context.Background(), message)
+	br, err := client.SendEachForMulticast(context.Background(), message)


The function receives a ctx context.Context parameter, but context.Background() is used here. To allow for proper context propagation (for cancellation, deadlines, tracing, etc.), you should use the ctx variable that is passed into the function.

Suggested change

br, err := client.SendEachForMulticast(context.Background(), message)

br, err := client.SendEachForMulticast(ctx, message)

gemini-code-assist · 2026-03-09T22:10:44Z

snippets/messaging.go

 	}

-	br, err := client.SendMulticast(context.Background(), message)
+	br, err := client.SendEachForMulticast(context.Background(), message)


With this change, the sendMulticastAndHandleErrors function has become functionally identical to the existing sendEachForMulticastAndHandleErrors function. This introduces code duplication. To improve maintainability, please consider removing this function and updating any callers to use sendEachForMulticastAndHandleErrors.

jonathanedey · 2026-03-10T14:50:35Z

snippets/messaging.go

 	// [END send_to_condition_golang]
 }

 func sendAll(ctx context.Context, client *messaging.Client) {


I think we can remove these 3 snippets completely since there are no longer referenced in devsite and we already have the migrated version of the snippets.

https://firebase.google.com/docs/cloud-messaging/send/admin-sdk#go_1

chore(snippets): updated code samples to use ADC and supported APIs

54a53aa

lahirumaramba requested a review from jonathanedey March 9, 2026 22:07

gemini-code-assist bot reviewed Mar 9, 2026

View reviewed changes

jonathanedey reviewed Mar 10, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(snippets): updated code samples to use ADC and supported APIs#752

chore(snippets): updated code samples to use ADC and supported APIs#752
lahirumaramba wants to merge 1 commit intodevfrom
lm-update-snippet

lahirumaramba commented Mar 9, 2026

Uh oh!

gemini-code-assist bot commented Mar 9, 2026

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

gemini-code-assist bot Mar 9, 2026

Uh oh!

gemini-code-assist bot Mar 9, 2026

Uh oh!

gemini-code-assist bot Mar 9, 2026

Uh oh!

gemini-code-assist bot Mar 9, 2026

Uh oh!

gemini-code-assist bot Mar 9, 2026

Uh oh!

jonathanedey Mar 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	br, err := client.SendEach(context.Background(), messages)
	br, err := client.SendEach(ctx, messages)

	br, err := client.SendEachForMulticast(context.Background(), message)
	br, err := client.SendEachForMulticast(ctx, message)

Conversation

lahirumaramba commented Mar 9, 2026

Uh oh!

gemini-code-assist bot commented Mar 9, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist bot Mar 9, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Mar 9, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Mar 9, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Mar 9, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Mar 9, 2026

Choose a reason for hiding this comment

Uh oh!

jonathanedey Mar 10, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants