Skip to content

feat(fcm): Add support for bandwidth constrained and restricted satellite APIs#502

Merged
jonathanedey merged 1 commit intomainfrom
je-satellite-apis
Mar 5, 2026
Merged

feat(fcm): Add support for bandwidth constrained and restricted satellite APIs#502
jonathanedey merged 1 commit intomainfrom
je-satellite-apis

Conversation

@jonathanedey
Copy link
Collaborator

@jonathanedey jonathanedey commented Mar 2, 2026

This change introduces the BandwidthConstrainedOk and RestrictedSatelliteOk properties to the AndroidConfig object to give developers more granular control over message delivery in resource-constrained environments. By configuring these options, developers can explicitly specify whether a notification should be allowed to be delivered when the receiving device is in a bandwidth-constrained state or when it is connected via a restricted satellite network.

@jonathanedey jonathanedey added the release:stage Stage a release candidate label Mar 2, 2026
@gemini-code-assist
Copy link

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the Firebase Cloud Messaging (FCM) capabilities by allowing developers to specify delivery preferences for Android devices operating under specific network constraints. By adding two new boolean flags to the AndroidConfig object, the system can now be configured to permit or restrict message delivery when a device is using a bandwidth-constrained network or a restricted satellite connection, thereby optimizing resource usage and ensuring critical messages reach their intended recipients in challenging environments.

Highlights

  • New AndroidConfig Properties: Introduced BandwidthConstrainedOk and RestrictedSatelliteOk boolean properties to the AndroidConfig object, allowing developers to control message delivery based on network conditions.
  • Enhanced Message Delivery Control: These new properties provide granular control over whether FCM messages should be delivered when a device is in a bandwidth-constrained state (e.g., Data Saver mode) or connected via a restricted satellite network.
  • Test Coverage: Added integration and unit tests to validate the functionality and serialization/deserialization of the new BandwidthConstrainedOk and RestrictedSatelliteOk properties within AndroidConfig.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • FirebaseAdmin/FirebaseAdmin.IntegrationTests/FirebaseMessagingTest.cs
    • Added BandwidthConstrainedOk and RestrictedSatelliteOk properties to AndroidConfig instances in SendAsync test.
    • Added BandwidthConstrainedOk and RestrictedSatelliteOk properties to AndroidConfig instances in SendEachAsync test.
  • FirebaseAdmin/FirebaseAdmin.Tests/Messaging/MessageTest.cs
    • Included BandwidthConstrainedOk and RestrictedSatelliteOk in AndroidConfig object creation for testing.
    • Added bandwidth_constrained_ok and restricted_satellite_ok to JSON object for AndroidConfig serialization test.
    • Set BandwidthConstrainedOk and RestrictedSatelliteOk values for AndroidConfig deserialization test.
    • Added assertions for BandwidthConstrainedOk and RestrictedSatelliteOk during AndroidConfig deserialization verification.
  • FirebaseAdmin/FirebaseAdmin/Messaging/AndroidConfig.cs
    • Added BandwidthConstrainedOk property with JSON property attribute and XML documentation.
    • Added RestrictedSatelliteOk property with JSON property attribute and XML documentation.
    • Included BandwidthConstrainedOk and RestrictedSatelliteOk in the CopyAndValidate method.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for BandwidthConstrainedOk and RestrictedSatelliteOk properties to the AndroidConfig object. The implementation includes adding the nullable boolean properties with appropriate JSON serialization attributes to AndroidConfig.cs. The CopyAndValidate method has been correctly updated to handle these new properties. The pull request also includes updates to unit tests in MessageTest.cs to verify serialization and deserialization, and integration tests in FirebaseMessagingTest.cs to ensure the new properties are correctly handled in API requests. The changes appear correct and complete.

Copy link
Member

@lahirumaramba lahirumaramba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM!

@jonathanedey jonathanedey merged commit abfc998 into main Mar 5, 2026
6 checks passed
@jonathanedey jonathanedey deleted the je-satellite-apis branch March 5, 2026 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release:stage Stage a release candidate release-note

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants