Skip to content

feat(kits): add test script to all packages under kits - #2945

Open
inlined wants to merge 3 commits into
kitsfrom
add-kits-test-scripts
Open

feat(kits): add test script to all packages under kits#2945
inlined wants to merge 3 commits into
kitsfrom
add-kits-test-scripts

Conversation

@inlined

@inlined inlined commented Aug 13, 2026

Copy link
Copy Markdown
Member

Adds a test script to every package under kits/. Runs vitest for packages with a tests folder, and prints a warning for packages without tests.

@inlined
inlined requested a review from a team as a code owner August 13, 2026 23:50

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request configures testing scripts across various packages in the kits/ directory, introducing vitest as a test runner for several packages and placeholder warnings for others. It also updates the workspace configuration in lerna.json and pnpm-workspace.yaml to include the kits/ directory, and adds a base TypeScript configuration. The reviewer suggests enabling strict type checking (strict: true) in the base TypeScript configuration to enforce stronger type guarantees and improve code quality across the workspace.

Comment thread tsconfig.base.json Outdated
"declaration": true,
"declarationMap": true,
"sourceMap": true,
"strict": false,

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Consider enabling strict type checking (strict: true) in the base TypeScript configuration. This enforces stronger type guarantees, helps catch potential runtime errors during compilation, and ensures consistent code quality across all packages in the workspace.

Suggested change
"strict": false,
"strict": true,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants