Conversation
…s and restore version spec
…ean race condition
…ery-export Security Audit & Remediation: firestore-bigquery-export
There was a problem hiding this comment.
Code Review
This pull request removes the node-fetch and rimraf dependencies, replacing rimraf with native Node.js commands in clean scripts, and updates various package dependencies. Feedback on these changes points out that the newly added --sort flag in the Lerna build command is invalid and will cause build failures. Additionally, it is recommended to replace the any type assertion in index.ts with a more specific type structure to maintain TypeScript's type safety.
| "lint": "prettier --list-different \"**/*.{js,md,yml,ts,json,yaml}\"", | ||
| "clean": "lerna run --parallel clean && lerna clean", | ||
| "build": "lerna run build", | ||
| "build": "lerna run --sort build", |
There was a problem hiding this comment.
The --sort option is not a valid flag for lerna run and will cause the build command to fail with an unknown option error. By default, Lerna already runs scripts in topological (dependency) order. If you want to ensure topological sorting, the default lerna run build is sufficient.
| "build": "lerna run --sort build", | |
| "build": "lerna run build", |
| headers: { "Content-Type": "application/json" }, | ||
| }); | ||
| const responseJson = await response.json(); | ||
| const responseJson: any = await response.json(); |
There was a problem hiding this comment.
Using any as a type assertion disables TypeScript's type safety checks. Since the response from a callable function has a known expected structure (containing either a result.data or data property), we can use a more specific type assertion to maintain type safety while still allowing the underlying data to be of any type.
const responseJson = (await response.json()) as {
result?: { data?: any };
data?: any;
};
No description provided.