Skip to content

sync next with master#2893

Merged
CorieW merged 5 commits into
nextfrom
master
Jun 24, 2026
Merged

sync next with master#2893
CorieW merged 5 commits into
nextfrom
master

Conversation

@CorieW

@CorieW CorieW commented Jun 24, 2026

Copy link
Copy Markdown
Member

No description provided.

@CorieW CorieW requested a review from a team as a code owner June 24, 2026 23:49
@CorieW CorieW merged commit 43e4b6c into next Jun 24, 2026
21 checks passed

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the node-fetch and rimraf dependencies, replacing rimraf with native Node.js commands in clean scripts, and updates various package dependencies. Feedback on these changes points out that the newly added --sort flag in the Lerna build command is invalid and will cause build failures. Additionally, it is recommended to replace the any type assertion in index.ts with a more specific type structure to maintain TypeScript's type safety.

Comment thread package.json
"lint": "prettier --list-different \"**/*.{js,md,yml,ts,json,yaml}\"",
"clean": "lerna run --parallel clean && lerna clean",
"build": "lerna run build",
"build": "lerna run --sort build",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The --sort option is not a valid flag for lerna run and will cause the build command to fail with an unknown option error. By default, Lerna already runs scripts in topological (dependency) order. If you want to ensure topological sorting, the default lerna run build is sufficient.

Suggested change
"build": "lerna run --sort build",
"build": "lerna run build",

headers: { "Content-Type": "application/json" },
});
const responseJson = await response.json();
const responseJson: any = await response.json();

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Using any as a type assertion disables TypeScript's type safety checks. Since the response from a callable function has a known expected structure (containing either a result.data or data property), we can use a more specific type assertion to maintain type safety while still allowing the underlying data to be of any type.

      const responseJson = (await response.json()) as {
        result?: { data?: any };
        data?: any;
      };

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants