feat: implement disconnect detection, cancel pushes on disconnect#1641
Draft
jescalada wants to merge 1 commit into
Draft
feat: implement disconnect detection, cancel pushes on disconnect#1641jescalada wants to merge 1 commit into
jescalada wants to merge 1 commit into
Conversation
✅ Deploy Preview for endearing-brigadeiros-63f9d0 canceled.
|
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1641 +/- ##
==========================================
- Coverage 85.87% 85.76% -0.12%
==========================================
Files 84 84
Lines 8109 8143 +34
Branches 1376 1384 +8
==========================================
+ Hits 6964 6984 +20
- Misses 1117 1129 +12
- Partials 28 30 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implements disconnect detection which marks pushes as canceled if the connection to the client is lost (such as when sending SIGINT after calling
git push, or internet disconnection).Originally developed in Fogwall, and explained here. This PR demonstrates that implementing persistent clones isn't necessary for detecting client disconnects.
A new step called
clientDisconnectedis added if the connection was lost - so the UI clearly reports the canceled status and reason for canceling:Client-side
Server-side
Note that
clearBareCloneruns in thefinallyblock (right afterclientDisconnected"step" is logged.Related Issue
Resolves #
Checklist
General
Documentation
Tests
npm test)npm run lintandnpm run format:check)npm run check-types)